From: David Woodhouse <dwmw2@infradead.org>
To: Paolo Bonzini <pbonzini@redhat.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: seanjc@google.com, Filippo Sironi <sironi@amazon.de>
Subject: Re: [PATCH 0/2] KVM: x86: cleanup and fix userspace interrupt window
Date: Fri, 27 Nov 2020 12:49:33 +0000 [thread overview]
Message-ID: <1eaaefbaf996f5e75d072863666aa3111d7b42f3.camel@infradead.org> (raw)
In-Reply-To: <20201127112114.3219360-1-pbonzini@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 905 bytes --]
On Fri, 2020-11-27 at 06:21 -0500, Paolo Bonzini wrote:
> This is my take on the split irqchip bug that David reported. It's a
> much more complicated patch, but I think it really gets to the bottom
> of the issue and the code is clearer.
Looks good to me; thanks. With the exception of the stray apostrophe
already noted, both:
Reviewed-by: David Woodhouse <dwmw@amazon.co.uk>
Tested-by: David Woodhouse <dwmw@amazon.co.uk>
There is a slight caveat that I think we're accepting ExtINT from
userspace PIC sooner than we should, and queuing it up for delivery in
the kernel.
Whereas real hardware might not issue the INTA cycle to ask the PIC
what vector it wants until later. By which time the PIC might give a
different answer. But I don't think anyone cares, even if it can make
an observable difference in practice. And I'm not sure that it's new
with your patches either.
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5174 bytes --]
prev parent reply other threads:[~2020-11-27 12:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 11:21 [PATCH 0/2] KVM: x86: cleanup and fix userspace interrupt window Paolo Bonzini
2020-11-27 11:21 ` [PATCH 1/2] KVM: x86: handle !lapic_in_kernel case in kvm_cpu_*_extint Paolo Bonzini
2020-11-27 11:56 ` David Woodhouse
2020-11-27 12:52 ` Filippo Sironi
2020-11-27 11:21 ` [PATCH 2/2] KVM: x86: Fix split-irqchip vs interrupt injection window request Paolo Bonzini
2020-11-27 12:53 ` Filippo Sironi
2021-04-09 7:14 ` Lai Jiangshan
2021-04-12 21:43 ` Sean Christopherson
2021-04-13 11:03 ` Lai Jiangshan
2021-04-13 12:15 ` Paolo Bonzini
2021-04-14 2:28 ` Lai Jiangshan
2021-04-14 16:58 ` Paolo Bonzini
2021-04-15 0:59 ` Lai Jiangshan
2021-04-15 6:07 ` Paolo Bonzini
2021-04-15 8:06 ` Lai Jiangshan
2021-04-13 12:10 ` Paolo Bonzini
2020-11-27 12:49 ` David Woodhouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1eaaefbaf996f5e75d072863666aa3111d7b42f3.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=sironi@amazon.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).