From: Joe Perches <joe@perches.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
zhong jiang <zhongjiang@huawei.com>,
davem@davemloft.net
Cc: benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] ide: Use NULL to compare with pointer-typed value rather than 0
Date: Sat, 18 Aug 2018 09:26:16 -0700 [thread overview]
Message-ID: <1ee3e90112269452b545bba54356bdba894b275c.camel@perches.com> (raw)
In-Reply-To: <94bdada0-e0f9-4dd2-ed6d-ad84f7114954@cogentembedded.com>
On Sat, 2018-08-18 at 19:21 +0300, Sergei Shtylyov wrote:
> On 08/18/2018 07:15 PM, Joe Perches wrote:
> > > > We should use NULL to compare with pointer-typed value rather than
> > > > 0. The issue is detected with the help of Coccinelle.
> > >
> > > Your description stopped to match the patch in v2.
> > > Actually, this X == NULL to !x preference is largely spocific to netdev...
> > > Although, IDE maintainer is the same now person. :-)
[]
> > > > diff --git a/drivers/ide/pmac.c b/drivers/ide/pmac.c
[]
> > > > @@ -1682,7 +1682,7 @@ static int pmac_ide_init_dma(ide_hwif_t *hwif, const struct ide_port_info *d)
> > > > /* We won't need pci_dev if we switch to generic consistent
> > > > * DMA routines ...
> > > > */
> > > > - if (dev == NULL || pmif->dma_regs == 0)
> > > > + if (!dev || !pmif->dma_regs)
> > > > return -ENODEV;
> > > > /*
> > > > * Allocate space for the DBDMA commands.
[]
> > Perhaps discourage trivial changes to this old subsystem.
> >
> > checkpatch could bleat something if a patch was submitted for ide
> > if the IDE MAINTAINERS entry was marked obsolete.
>
> Note that the IDE fixes are still OK...
The checkpatch obsolete message is
<filename> is marked as 'obsolete' in the MAINTAINERS hierarchy. No unnecessary modifications please.
---
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index e9336962d0f2..3c4992cf5249 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -6933,7 +6933,7 @@ M: "David S. Miller" <davem@davemloft.net>
> > L: linux-ide@vger.kernel.org
> > Q: http://patchwork.ozlabs.org/project/linux-ide/list/
> > T: git git://git.kernel.org/pub/scm/linux/kernel/git/davem/ide.git
> > -S: Maintained
> > +S: Maintained / Obsolete (prefer LIBATA)
>
> What about "S: Odd Fixes"? Perhaps it better reflects the reality...
That'd be up to David.
next prev parent reply other threads:[~2018-08-18 16:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-18 6:16 [PATCHv2] ide: Use NULL to compare with pointer-typed value rather than 0 zhong jiang
2018-08-18 15:53 ` Sergei Shtylyov
2018-08-18 16:15 ` Joe Perches
2018-08-18 16:21 ` Sergei Shtylyov
2018-08-18 16:26 ` Joe Perches [this message]
2018-08-18 16:25 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ee3e90112269452b545bba54356bdba894b275c.camel@perches.com \
--to=joe@perches.com \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).