From: subashab@codeaurora.org
To: patchwork-bot+netdevbpf@kernel.org
Cc: Nathan Chancellor <nathan@kernel.org>,
stranche@codeaurora.org, davem@davemloft.net, kuba@kernel.org,
ndesaulniers@google.com, sharathv@codeaurora.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
clang-built-linux@googlegroups.com
Subject: Re: [PATCH net-next] net: ethernet: rmnet: Restructure if checks to avoid uninitialized warning
Date: Thu, 03 Jun 2021 23:15:10 -0600 [thread overview]
Message-ID: <1f6f8246f0cd477c0b1e2b88b4ec825a@codeaurora.org> (raw)
In-Reply-To: <162276000605.13062.14467575723320615318.git-patchwork-notify@kernel.org>
On 2021-06-03 16:40, patchwork-bot+netdevbpf@kernel.org wrote:
> Hello:
>
> This patch was applied to netdev/net-next.git (refs/heads/master):
>
> On Thu, 3 Jun 2021 10:34:10 -0700 you wrote:
>> Clang warns that proto in rmnet_map_v5_checksum_uplink_packet() might
>> be
>> used uninitialized:
>>
>> drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c:283:14: warning:
>> variable 'proto' is used uninitialized whenever 'if' condition is
>> false
>> [-Wsometimes-uninitialized]
>> } else if (skb->protocol == htons(ETH_P_IPV6)) {
>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c:295:36: note:
>> uninitialized use occurs here
>> check = rmnet_map_get_csum_field(proto, trans);
>> ^~~~~
>> drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c:283:10: note:
>> remove the 'if' if its condition is always true
>> } else if (skb->protocol == htons(ETH_P_IPV6)) {
>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c:270:11: note:
>> initialize the variable 'proto' to silence this warning
>> u8 proto;
>> ^
>> = '\0'
>> 1 warning generated.
>>
>> [...]
>
> Here is the summary with links:
> - [net-next] net: ethernet: rmnet: Restructure if checks to avoid
> uninitialized warning
> https://git.kernel.org/netdev/net-next/c/118de6106735
>
> You are awesome, thank you!
> --
> Deet-doot-dot, I am a bot.
> https://korg.docs.kernel.org/patchwork/pwbot.html
Hi Nathan
Can you tell why CLANG detected this error.
Does it require a bug fix.
next prev parent reply other threads:[~2021-06-04 5:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 17:34 [PATCH net-next] net: ethernet: rmnet: Restructure if checks to avoid uninitialized warning Nathan Chancellor
2021-06-03 22:40 ` patchwork-bot+netdevbpf
2021-06-04 5:15 ` subashab [this message]
2021-06-04 16:54 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f6f8246f0cd477c0b1e2b88b4ec825a@codeaurora.org \
--to=subashab@codeaurora.org \
--cc=clang-built-linux@googlegroups.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=patchwork-bot+netdevbpf@kernel.org \
--cc=sharathv@codeaurora.org \
--cc=stranche@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).