From: David Oberhollenzer <david.oberhollenzer@sigma-star.at>
To: Eric Biggers <ebiggers@google.com>, Richard Weinberger <richard@nod.at>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-fscrypt@vger.kernel.org, david@sigma-star.at
Subject: Re: [PATCH] ubifs: Return -ENOKEY from rename if encryption keys are missing
Date: Wed, 26 Apr 2017 13:48:10 +0200 [thread overview]
Message-ID: <1f759fee-337f-903a-0eb0-5b364cd35e6f@sigma-star.at> (raw)
In-Reply-To: <20170425175442.GB41477@google.com>
On 04/25/2017 07:54 PM, Eric Biggers wrote:
> Did you test that this change actually does anything? Unlike ext4 and f2fs,
> ubifs calls fscrypt_setup_filename() from its rename methods rather than through
> a helper function ${FS}_find_entry(). Therefore it's able to pass in lookup=0,
> which means that the key is required. So it should already be failing with
> ENOKEY. You can verify this by running xfstests generic/419.
Actually, running xfstests was how this cropped up in the first place.
The UBIFS rename and xrename functions allready call
fscrypt_setup_filename with lookup=0, however there are other tests
before that call and moving them around causes generic/419 to fail
at a different place where EPERM was expected.
Therefore I concluded that the safest way to fix this might be to
simply copy the way the checks are handled in ext4.
With recent xfstests + UBIFS support patch, after applying this patch,
generic/419 passes.
David
next prev parent reply other threads:[~2017-04-26 11:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-24 21:46 [PATCH] ubifs: Return -ENOKEY from rename if encryption keys are missing Richard Weinberger
2017-04-25 17:54 ` Eric Biggers
2017-04-26 11:48 ` David Oberhollenzer [this message]
2017-04-26 22:52 ` Eric Biggers
2017-04-27 8:59 ` David Oberhollenzer
2017-04-27 19:34 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f759fee-337f-903a-0eb0-5b364cd35e6f@sigma-star.at \
--to=david.oberhollenzer@sigma-star.at \
--cc=david@sigma-star.at \
--cc=ebiggers@google.com \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).