From: Bixuan Cui <cuibixuan@huawei.com>
To: Thomas Gleixner <tglx@linutronix.de>, <linux-kernel@vger.kernel.org>
Cc: <maz@kernel.org>, <john.wanghui@huawei.com>
Subject: Re: [PATCH -next] irqdomain: fix overflow error
Date: Wed, 15 Sep 2021 17:38:26 +0800 [thread overview]
Message-ID: <1fe1aa97-97dc-4f55-186e-7aace630c8f1@huawei.com> (raw)
In-Reply-To: <87pmtab7no.ffs@tglx>
On 2021/9/15 15:49, Thomas Gleixner wrote:
> On Wed, Sep 15 2021 at 10:03, Bixuan Cui wrote:
>> On 2021/9/14 19:56, Thomas Gleixner wrote:
>>
>> And kernel/irq/irqdomain.c
>> struct irq_domain *irq_domain_create_simple(struct fwnode_handle *fwnode,
>> unsigned int size,
>> unsigned int first_irq,
>> const struct irq_domain_ops *ops,
>> void *host_data)
>> {
>> struct irq_domain *domain;
>>
>> domain = __irq_domain_add(fwnode, size, size, 0, ops, host_data);
>>
>> All 'size' passed to __irq_domain_add() are unsigned int.
>>
>> So I think it's more appropriate to replace it with unsigned int.
> Appropriate is not really a technical reason. Making the code consistent
> is.
>
> But that has nothing to do with the completely bogus compiler warning in
> the changelog you provided.
Hello,
It is a real compilation warning, It occurs when compiled with
.config(https://syzkaller.appspot.com/text?tag=KernelConfig&x=4d196bb8b1e038c0).
This is my compile log:
// cp .config from https://syzkaller.appspot.com/text?tag=KernelConfig&x=4d196bb8b1e038c0
$ make menuconfig
$ make kernel/irq/irqdomain.o
SYNC include/config/auto.conf.cmd
DESCEND objtool
CALL scripts/atomic/check-atomics.sh
CALL scripts/checksyscalls.sh
CC kernel/irq/irqdomain.o
In file included from ./include/linux/resource_ext.h:11:0,
from ./include/linux/acpi.h:14,
from kernel/irq/irqdomain.c:5:
In function ‘kmalloc_node’,
inlined from ‘kzalloc_node.constprop’ at ./include/linux/slab.h:743:9,
inlined from ‘__irq_domain_add’ at kernel/irq/irqdomain.c:153:9:
./include/linux/slab.h:618:9: warning: argument 1 value ‘18446744073709551615’ exceeds maximum object size 9223372036854775807 [-Walloc-size-larger-than=]
return __kmalloc_node(size, flags, node);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./include/linux/slab.h: In function ‘__irq_domain_add’:
./include/linux/slab.h:455:7: note: in a call to allocation function ‘__kmalloc_node’ declared here
void *__kmalloc_node(size_t size, gfp_t flags, int node) __assume_slab_alignment __malloc;
^~~~~~~~~~~~~~
Thanks,
Bixuan Cui
next prev parent reply other threads:[~2021-09-15 9:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 1:46 [PATCH -next] irqdomain: fix overflow error Bixuan Cui
2021-09-14 11:56 ` Thomas Gleixner
2021-09-15 2:03 ` Bixuan Cui
2021-09-15 7:49 ` Thomas Gleixner
2021-09-15 9:38 ` Bixuan Cui [this message]
2021-09-16 2:37 ` Bixuan Cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fe1aa97-97dc-4f55-186e-7aace630c8f1@huawei.com \
--to=cuibixuan@huawei.com \
--cc=john.wanghui@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).