linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@suse.cz>
To: Andrea Arcangeli <andrea@suse.de>,
	Linus Torvalds <torvalds@transmeta.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>
Subject: Re: softirq bugs in pre2
Date: Mon, 11 Jun 2001 23:58:46 +0200	[thread overview]
Message-ID: <20010611235846.B130@bug.ucw.cz> (raw)
In-Reply-To: <20010611193703.S5468@athlon.random>
In-Reply-To: <20010611193703.S5468@athlon.random>; from Andrea Arcangeli on Mon, Jun 11, 2001 at 07:37:03PM +0200

Hi!

> diff -urN 2.4.4/include/linux/condsched.h lowlat/include/linux/condsched.h
> --- 2.4.4/include/linux/condsched.h	Thu Jan  1 01:00:00 1970
> +++ lowlat/include/linux/condsched.h	Sun Apr 29 18:33:13 2001
> @@ -0,0 +1,14 @@
> +#ifndef _LINUX_CONDSCHED_H
> +#define _LINUX_CONDSCHED_H
> +
> +#ifndef __ASSEMBLY__
> +#define conditional_schedule() \
> +do { \
> +	if (current->need_resched) { \
> +		current->state = TASK_RUNNING; \
> +		schedule(); \
> +	} \
> +} while(0)
> +#endif
> +
> +#endif

I do not think that conditional schedule is worth its own header
file. I see you want to potentiatlly replace it with assembly, but
can't that be done in, say, system.h too? [Ok, you'd have to create
linux/system.h, but that can be called cleanup.]
								Pavel
-- 
I'm pavel@ucw.cz. "In my country we have almost anarchy and I don't care."
Panos Katsaloulis describing me w.r.t. patents at discuss@linmodems.org

      parent reply	other threads:[~2001-06-12  8:41 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-06-11 17:37 softirq bugs in pre2 Andrea Arcangeli
2001-06-11 19:09 ` Linus Torvalds
2001-06-11 19:41   ` Andrea Arcangeli
2001-06-11 20:55   ` Alan Cox
2001-06-11 22:42   ` Gigabit Intel NIC? - Intel Gigabit Ethernet Pro/1000T Shawn Starr
2001-06-12 16:34     ` Alan Cox
2001-06-12 17:20       ` Riley Williams
2001-06-13 10:25         ` Ion Badulescu
2001-06-13 12:40           ` Ralf Baechle
2001-06-13 17:07             ` James Sutherland
2001-06-14 20:59           ` Riley Williams
2001-06-14 21:10             ` Jeff Garzik
2001-06-14 21:14             ` Matthew Jacob
2001-06-14 21:29             ` Alan Cox
2001-06-14 21:52               ` Matthew Dharm
2001-06-14 21:58                 ` Alan Cox
2001-06-14 22:03                 ` Matthew Jacob
2001-06-15  2:20             ` Shawn Starr
2001-06-12  2:54   ` softirq bugs in pre2 Andrew Morton
2001-06-11 21:58 ` Pavel Machek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010611235846.B130@bug.ucw.cz \
    --to=pavel@suse.cz \
    --cc=andrea@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).