linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hiroshi Takekawa <sian@big.or.jp>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] Re: make bzImage fails on 2.5.38
Date: Sun, 22 Sep 2002 15:43:31 +0900 (JST)	[thread overview]
Message-ID: <20020922.154331.51732591.sian@big.or.jp> (raw)
In-Reply-To: <Pine.GSO.4.21.0209220229480.22740-100000@weyl.math.psu.edu>


Here's diff for this.
No sooner than had I made this diff than I read your mail...
But just replacing devfs_handle with cdroms causes weird
cdroms/cdroms/cdrom0 symlink.
Please review.

> > First post to the list, I've followed the format given in REPORTING-BUGS
> > 
> > 1. make bzImage fails on 2.5.38

> Arrgh.

> ed fs/partitions/check.c <<EOF
> 365s/devfs_handle/cdroms/
> w
> q
> EOF

diff -Naur linux-2.5.38.vanilla/fs/partitions/check.c linux-2.5.38/fs/partitions/check.c
--- linux-2.5.38.vanilla/fs/partitions/check.c	Sun Sep 22 15:27:26 2002
+++ linux-2.5.38/fs/partitions/check.c	Sun Sep 22 15:17:10 2002
@@ -338,17 +338,13 @@
 static void devfs_create_cdrom(struct gendisk *dev)
 {
 #ifdef CONFIG_DEVFS_FS
-	int pos = 0;
-	devfs_handle_t dir, slave;
-	unsigned int devfs_flags = DEVFS_FL_DEFAULT;
-	char dirname[64], symlink[16];
 	char vname[23];
 
 	if (!cdroms)
 		cdroms = devfs_mk_dir (NULL, "cdroms", NULL);
 
 	dev->number = devfs_alloc_unique_number(&cdrom_numspace);
-	sprintf(vname, "cdroms/cdrom%d", dev->number);
+	sprintf(vname, "cdrom%d", dev->number);
 	if (dev->de) {
 		int pos;
 		devfs_handle_t slave;
@@ -362,13 +358,13 @@
 		pos = devfs_generate_path(dev->disk_de, rname+3, sizeof(rname)-3);
 		if (pos >= 0) {
 			strncpy(rname + pos, "../", 3);
-			devfs_mk_symlink(devfs_handle, vname,
+			devfs_mk_symlink(cdroms, vname,
 					 DEVFS_FL_DEFAULT,
 					 rname + pos, &slave, NULL);
 			devfs_auto_unregister(dev->de, slave);
 		}
 	} else {
-		dev->disk_de = devfs_register (NULL, vname, DEVFS_FL_DEFAULT,
+		dev->disk_de = devfs_register (cdroms, vname, DEVFS_FL_DEFAULT,
 				    dev->major, dev->first_minor,
 				    S_IFBLK | S_IRUGO | S_IWUGO,
 				    dev->fops, NULL);

  reply	other threads:[~2002-09-22  6:38 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-22  4:34 Linux 2.5.38 Linus Torvalds
2002-09-22  6:16 ` make bzImage fails on 2.5.38 Aniruddha Shankar
2002-09-22  6:31   ` Alexander Viro
2002-09-22  6:43     ` Hiroshi Takekawa [this message]
2002-09-22  6:56     ` Aniruddha Shankar
2002-09-22  9:54     ` Arjan van de Ven
2002-09-22 10:14       ` Alexander Viro
2002-09-22 10:53 ` [BUG,PATCH] 2.5.38 floppy Philipp Matthias Hahn
2002-09-22 13:09 ` Linux 2.5.38 Adrian Bunk
2002-09-22 13:21   ` Alexander Viro
2002-09-22 20:02 ` Jochen Friedrich
2002-09-22 20:07   ` Arnaldo Carvalho de Melo
2002-09-22 20:22   ` Jochen Friedrich
2002-09-23  1:44     ` Peter Rival
2002-09-23  2:32       ` Linus Torvalds
2002-09-23  2:39         ` Jeff Garzik
2002-09-22 21:59 ` [PATCH] #include <linux/version.h> missing in drivers/usb/host/ohci-hcd.c Luc Van Oostenryck
2002-09-23 19:51   ` Greg KH
2002-09-23  0:19 ` Linux 2.5.38 Michel Eyckmans (MCE)
2002-09-23  0:57   ` Skip Ford
2002-09-23  2:27   ` Linus Torvalds
2002-09-23 23:06     ` Michel Eyckmans (MCE)
2002-09-23 23:23       ` Linus Torvalds
2002-09-24 22:42         ` Michel Eyckmans (MCE)
2002-09-25 17:46           ` Bill Davidsen
2002-09-26  0:43             ` Russell King
2002-09-24 12:54   ` [PATCH] export find_task_by_pid() for 2.5.38 James Morris
2002-09-23 12:53 ` Linux 2.5.38 Clemens Schwaighofer
2002-09-23 15:28 ` Linux 2.5.38 [PATCH] IrDA Philipp Matthias Hahn
2002-09-23 22:04   ` Jean Tourrilhes
2002-09-26 20:40 ` [PATCH] Re: Linux 2.5.38 Rasmus Andersen
2002-09-26 21:12 ` Rasmus Andersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020922.154331.51732591.sian@big.or.jp \
    --to=sian@big.or.jp \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).