From: Andi Kleen <ak@suse.de>
To: Andi Kleen <ak@suse.de>, David Brownell <david-b@pacbell.net>,
linux-kernel@vger.kernel.org, greg@kroah.com, mochel@osdl.org,
linux-usb-devel@lists.sourceforge.net
Subject: Re: [linux-usb-devel] [RFC] consolidate /sbin/hotplug call for pci and usb
Date: Thu, 26 Sep 2002 03:01:05 +0200 [thread overview]
Message-ID: <20020926030105.A18617@wotan.suse.de> (raw)
In-Reply-To: <20020925174612.A13467@one-eyed-alien.net>
On Wed, Sep 25, 2002 at 05:46:12PM -0700, Matthew Dharm wrote:
> On Thu, Sep 26, 2002 at 02:33:50AM +0200, Andi Kleen wrote:
> > David Brownell <david-b@pacbell.net> writes:
> >
> > > > + /* stuff we want to pass to /sbin/hotplug */
> > > > + envp[i++] = scratch;
> > > > + scratch += sprintf (scratch, "PCI_CLASS=%04X", pdev->class) + 1;
> > > > +
> > > > + envp[i++] = scratch;
> > > > + scratch += sprintf (scratch, "PCI_ID=%04X:%04X",
> > > > + pdev->vendor, pdev->device) + 1;
> > >
> > > And so forth. Use "snprintf" and prevent overrunning those buffers...
> >
> > Hmm? An %04X format is perfectly bounded.
>
> Technically, it isn't bounded. The field will expand if the value exceeds
> 4 digits.
It is bounded to 8 characters on linux systems (where int is always 32bit)
-Andi
next prev parent reply other threads:[~2002-09-26 0:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20020925212955.GA32487@kroah.com.suse.lists.linux.kernel>
[not found] ` <3D9250CD.7090409@pacbell.net.suse.lists.linux.kernel>
2002-09-26 0:33 ` [linux-usb-devel] [RFC] consolidate /sbin/hotplug call for pci and usb Andi Kleen
2002-09-26 0:46 ` Matthew Dharm
2002-09-26 1:01 ` Andi Kleen [this message]
2002-09-26 2:30 ` David Brownell
2002-09-25 21:29 Greg KH
2002-09-26 0:11 ` [linux-usb-devel] " David Brownell
2002-09-26 0:25 ` Greg KH
2002-09-26 2:44 ` David Brownell
2002-09-26 4:27 ` Greg KH
2002-09-26 16:14 ` David Brownell
2002-09-26 18:43 ` Greg KH
2002-09-26 19:32 ` David Brownell
2002-09-26 19:34 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020926030105.A18617@wotan.suse.de \
--to=ak@suse.de \
--cc=david-b@pacbell.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=mochel@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).