From: Russell King <rmk@arm.linux.org.uk>
To: Tim Waugh <twaugh@redhat.com>
Cc: Marek Michalkiewicz <marekm@amelek.gda.pl>,
serial24@macrolink.com, linux-kernel@vger.kernel.org
Subject: Re: [patch] fix parport_serial / serial link order (for 2.4.20-pre8)
Date: Mon, 30 Sep 2002 10:49:28 +0100 [thread overview]
Message-ID: <20020930104928.C5119@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20020930094012.GC20605@redhat.com>; from twaugh@redhat.com on Mon, Sep 30, 2002 at 10:40:12AM +0100
On Mon, Sep 30, 2002 at 10:40:12AM +0100, Tim Waugh wrote:
> On Thu, Sep 26, 2002 at 10:05:16PM +0200, Marek Michalkiewicz wrote:
> > below is a patch that moves parport_serial.c from drivers/parport/
> > to drivers/char/ - this fixes the wrong link order when the drivers
> > are compiled into the kernel.
>
> What was wrong with the original, much smaller patch that you sent me
> previously (below)?
>
> I'm happy to accept whichever patch is the better.
Other than it's a gross hack rather than a fix. However, for 2.4, I
think this is probably the best solution without creating a risk of
other init ordering problems. Ed, any comments?
In 2.5, its easier to solve; we just need to make sure serial is
initialised before parport. This is easy, since serial now has its
own drivers/serial subdirectory.
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
next prev parent reply other threads:[~2002-09-30 9:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-26 20:05 [patch] fix parport_serial / serial link order (for 2.4.20-pre8) Marek Michalkiewicz
2002-09-27 1:18 ` Zwane Mwaikambo
2002-09-27 6:35 ` Marek Michalkiewicz
2002-09-28 4:24 ` Zwane Mwaikambo
2002-09-29 18:00 ` Marek Michalkiewicz
2002-09-29 19:14 ` Zwane Mwaikambo
2002-09-29 20:24 ` Marek Michalkiewicz
2002-09-30 9:20 ` Zwane Mwaikambo
2002-09-30 10:27 ` Marek Michalkiewicz
2002-09-30 9:40 ` Tim Waugh
2002-09-30 9:49 ` Russell King [this message]
2002-09-30 10:07 ` Marek Michalkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020930104928.C5119@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=marekm@amelek.gda.pl \
--cc=serial24@macrolink.com \
--cc=twaugh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).