From: John Bradford <john@grabjohn.com>
To: apodtele@mccammon.ucsd.edu (Alexei Podtelezhnikov)
Cc: linux-kernel@vger.kernel.org, rmk@arm.linux.org.uk
Subject: Re: [PATCH] 2.5.59 : sound/oss/vidc.c (CORRECTED)
Date: Sat, 8 Feb 2003 11:25:34 +0000 (GMT) [thread overview]
Message-ID: <200302081125.h18BPYbn000265@darkstar.example.net> (raw)
In-Reply-To: <Pine.LNX.4.44.0302071641420.18936-100000@chemcca61.ucsd.edu> from "Alexei Podtelezhnikov" at Feb 07, 2003 04:45:13 PM
>
> John Bradford (john@grabjohn.com) wrote:
>
> > 36 < hwrate < 3332
> ^^^^^^ should be 'newsize'
>
> Yeap, and the following couple of lines:
>
> /* 36 < newsize 3332; rounding it off
> * to the nearest power of 2, no less than 256
> */
> for (new2size = 384; new2size < newsize; new2size <<= 1);
> new2size -= new2size / 3;
>
> safely replace the whole following block:
>
> if (newsize < 208)
> newsize = 208;
> if (newsize > 4096)
> newsize = 4096;
> for (new2size = 128; new2size < newsize; new2size <<= 1);
> if (new2size - newsize > newsize - (new2size >> 1))
> new2size >>= 1;
> if (new2size > 4096) {
> printk(KERN_ERR "VIDC: error: dma buffer (%d) %d > 4K\n",
> newsize, new2size);
> new2size = 4096;
> }
>
> Would somebody test this?
The only change I'd make would be:
- /* 36 < newsize 3332; rounding it off
+ /* 36 <= newsize <= 3332; rounding it off
John
prev parent reply other threads:[~2003-02-08 11:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-08 0:45 [PATCH] 2.5.59 : sound/oss/vidc.c (CORRECTED) Alexei Podtelezhnikov
2003-02-08 11:25 ` John Bradford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200302081125.h18BPYbn000265@darkstar.example.net \
--to=john@grabjohn.com \
--cc=apodtele@mccammon.ucsd.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).