From: Gabriel Paubert <paubert@iram.es>
To: Tom Rini <trini@kernel.crashing.org>
Cc: "Randy.Dunlap" <rddunlap@osdl.org>,
randy.dunlap@verizon.net, linux-kernel@vger.kernel.org,
torvalds@transmeta.com
Subject: Re: [PATCH] move SWAP option in menu
Date: Thu, 6 Mar 2003 20:33:44 +0100 [thread overview]
Message-ID: <20030306193344.GA29166@iram.es> (raw)
In-Reply-To: <20030306184332.GA23580@ip68-0-152-218.tc.ph.cox.net>
On Thu, Mar 06, 2003 at 11:43:32AM -0700, Tom Rini wrote:
>
> How's this look? I picked MMU=x implies SWAP=x for defaults, just
> because that's how they were before...
I'd be very surprised if it were possible to have swap on a MMU-less
machine (no virtual memory, page faults, etc.). Except for this nitpick,
the patch looks fine, but my knowledge of MM is close to zero (and
also of the new config language, but I'll have to learn it soon).
> ===== init/Kconfig 1.10 vs edited =====
> --- 1.10/init/Kconfig Mon Feb 3 13:19:37 2003
> +++ edited/init/Kconfig Thu Mar 6 11:41:51 2003
> @@ -37,6 +37,16 @@
>
> menu "General setup"
>
> +config SWAP
> + bool "Support for paging of anonymous memory"
> + default y if MMU
> + default n if !MMU
Should rather be (from just reading kconfig-language.txt):
config SWAP
depends on MMU
bool "Support for paging of anonymous memory"
default y
Comments?
Gabriel.
next prev parent reply other threads:[~2003-03-06 19:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-05 4:36 [PATCH] move SWAP option in menu Randy.Dunlap
2003-03-05 18:17 ` Gabriel Paubert
2003-03-05 21:14 ` Randy.Dunlap
2003-03-06 18:43 ` Tom Rini
2003-03-06 18:49 ` Christoph Hellwig
2003-03-06 18:54 ` Tom Rini
2003-03-06 18:56 ` Christoph Hellwig
2003-03-06 19:33 ` Gabriel Paubert [this message]
2003-03-06 21:06 ` Alan Cox
2003-03-07 10:03 ` Gabriel Paubert
2003-03-07 12:41 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030306193344.GA29166@iram.es \
--to=paubert@iram.es \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@verizon.net \
--cc=rddunlap@osdl.org \
--cc=torvalds@transmeta.com \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).