From: Adrian Bunk <bunk@fs.tum.de>
To: James Bottomley <James.Bottomley@steeleye.com>
Cc: Alan Cox <alan@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: 2.5.64-ac3: 3c527.c doesn't compile
Date: Sat, 22 Mar 2003 09:23:30 +0100 [thread overview]
Message-ID: <20030322082329.GW6940@fs.tum.de> (raw)
In-Reply-To: <1047072894.3444.22.camel@mulgrave>
On Fri, Mar 07, 2003 at 03:34:52PM -0600, James Bottomley wrote:
> On Fri, 2003-03-07 at 15:03, Adrian Bunk wrote:
> > On Fri, Mar 07, 2003 at 12:56:44PM -0500, Alan Cox wrote:
> >
> > >...
> > > Linux 2.5.64-ac2
> > >...
> > > o Update 3c527 to modern locking (untested) (James Bottomley)
> > >...
> >
> > It seems even the compilation is untested?
>
> It builds for me fine in 2.5.64. Perhaps you misapplied the patch, or
> got a mangled one. The correct patch is below.
The patch in your mail was empty.
The problem is still present in 2.5.65-ac2, is the patch below correct?
> James
cu
Adrian
--- linux-2.5.65-ac2/drivers/net/3c527.c.old 2003-03-22 09:19:39.000000000 +0100
+++ linux-2.5.65-ac2/drivers/net/3c527.c 2003-03-22 09:20:44.000000000 +0100
@@ -624,7 +624,8 @@
struct mc32_local *lp = (struct mc32_local *)dev->priv;
int ioaddr = dev->base_addr;
int ret = 0;
-
+ unsigned long flags;
+
/*
* Wait for a command
*/
@@ -729,6 +730,7 @@
{
struct mc32_local *lp = (struct mc32_local *)dev->priv;
int ioaddr = dev->base_addr;
+ unsigned long flags;
spin_lock_irqsave(&lp->lock, flags);
@@ -948,7 +950,7 @@
u8 one=1;
u8 regs;
u16 descnumbuffs[2] = {TX_RING_LEN, RX_RING_LEN};
- unsigned_long flags;
+ unsigned long flags;
spin_lock_irqsave(&lp->lock, flags);
next prev parent reply other threads:[~2003-03-22 8:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-07 17:56 Linux 2.5.64-ac3 Alan Cox
2003-03-07 20:14 ` [patch] 2.5.64-ac3: fix a typo in ide-default.c Adrian Bunk
2003-03-07 20:33 ` [PATCH][TRIVIAL] Re: Linux 2.5.64-ac3 Maciej Soltysiak
2003-03-07 23:08 ` Alan Cox
2003-03-07 21:03 ` 2.5.64-ac3: 3c527.c doesn't compile Adrian Bunk
2003-03-07 21:34 ` James Bottomley
2003-03-22 8:23 ` Adrian Bunk [this message]
2003-03-09 1:58 ` Question about VISWS 2.5.64-ac3 Osamu Tomita
2003-03-09 2:16 ` New IDE codes in 2.5.64-ac3 Osamu Tomita
2003-03-09 20:53 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030322082329.GW6940@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=James.Bottomley@steeleye.com \
--cc=alan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).