From: Christoph Hellwig <hch@lst.de>
To: Pavel Roskin <proski@gnu.org>
Cc: linux-kernel@vger.kernel.org, hch@lst.de
Subject: Re: [PATCH] 2.5.68-bk1 crash in devfs_remove() for defpts files
Date: Mon, 21 Apr 2003 19:55:55 +0200 [thread overview]
Message-ID: <20030421195555.A28583@lst.de> (raw)
In-Reply-To: <Pine.LNX.4.55.0304211338540.1491@marabou.research.att.com>; from proski@gnu.org on Mon, Apr 21, 2003 at 01:49:18PM -0400
On Mon, Apr 21, 2003 at 01:49:18PM -0400, Pavel Roskin wrote:
> This patch
> helps, but it probably shouldn't be applied unless it turns out to be
> correct.
Right, the patch only hides the bug.
> By the way, I wonder why devfs_put(de) is called twice in a row in
> devfs_remove().
Once for the temporary reference we got from _devfs_find_entry,
the second time to actually make it go away.
Could you please try this patch?
--- 1.11/drivers/char/pty.c Mon Mar 31 03:16:19 2003
+++ edited/drivers/char/pty.c Mon Apr 21 18:32:46 2003
@@ -459,6 +459,7 @@
pts_driver[i].name_base = i*NR_PTYS;
pts_driver[i].num = ptm_driver[i].num;
pts_driver[i].other = &ptm_driver[i];
+ ptm_driver[i].flags |= TTY_DRIVER_NO_DEVFS;
pts_driver[i].table = pts_table[i];
pts_driver[i].termios = pts_termios[i];
pts_driver[i].termios_locked = pts_termios_locked[i];
next prev parent reply other threads:[~2003-04-21 17:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-21 17:49 [PATCH] 2.5.68-bk1 crash in devfs_remove() for defpts files Pavel Roskin
2003-04-21 17:55 ` Christoph Hellwig [this message]
2003-04-21 17:58 ` Christoph Hellwig
2003-04-21 18:53 ` Pavel Roskin
2003-04-21 19:00 ` Christoph Hellwig
2003-04-21 19:44 ` Pavel Roskin
2003-04-21 19:56 ` Christoph Hellwig
2003-04-21 20:35 ` Pavel Roskin
2003-04-21 20:44 ` Grzegorz Jaskiewicz
2003-04-21 20:56 ` Pavel Roskin
2003-04-24 7:39 ` Martin Schlemmer
2003-04-24 7:57 ` Grzegorz Jaskiewicz
2003-04-24 11:46 ` Martin Schlemmer
2003-04-24 12:03 ` Grzegorz Jaskiewicz
2003-04-21 20:57 ` Christoph Hellwig
2003-04-21 21:15 ` Pavel Roskin
2003-04-21 21:23 ` Christoph Hellwig
2003-04-21 21:45 ` Pavel Roskin
2003-04-21 22:25 ` Christoph Hellwig
2003-04-21 22:37 ` Pavel Roskin
2003-04-22 10:12 Chuck Ebbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030421195555.A28583@lst.de \
--to=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).