From: Stephan von Krawczynski <skraw@ithnet.com>
To: Marcelo Tosatti <marcelo@conectiva.com.br>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Linux 2.4.21-rc1
Date: Mon, 21 Apr 2003 21:58:24 +0200 [thread overview]
Message-ID: <20030421215824.5f5cec7e.skraw@ithnet.com> (raw)
In-Reply-To: <Pine.LNX.4.53L.0304211545580.12940@freak.distro.conectiva>
On Mon, 21 Apr 2003 15:47:32 -0300 (BRT)
Marcelo Tosatti <marcelo@conectiva.com.br> wrote:
>
> Here goes the first candidate for 2.4.21.
>
> Please test it extensively.
Hello Marcelo,
please consider below patch for inclusion. It prevents ide-scsi from freezing
the box under certain CD-burning activities. This is a bugfix. "rq->buffer"
gets trashed under certain conditions.
Rediffed to 2.4.21-rc1.
Thanks,
Stephan
--- linux/drivers/scsi/ide-scsi.c-orig 2003-04-21 21:41:05.000000000 +0200
+++ linux/drivers/scsi/ide-scsi.c 2003-04-21 21:42:11.000000000 +0200
@@ -321,7 +321,7 @@
{
idescsi_scsi_t *scsi = drive->driver_data;
struct request *rq = HWGROUP(drive)->rq;
- idescsi_pc_t *pc = (idescsi_pc_t *) rq->buffer;
+ idescsi_pc_t *pc = rq->special;
int log = test_bit(IDESCSI_LOG_CMD, &scsi->log);
u8 *scsi_buf;
unsigned long flags;
@@ -587,7 +587,7 @@
#endif /* IDESCSI_DEBUG_LOG */
if (rq->cmd == IDESCSI_PC_RQ) {
- return idescsi_issue_pc(drive, (idescsi_pc_t *) rq->buffer);
+ return idescsi_issue_pc (drive, rq->special);
}
printk(KERN_ERR "ide-scsi: %s: unsupported command in request "
"queue (%x)\n", drive->name, rq->cmd);
@@ -1083,7 +1083,7 @@
}
ide_init_drive_cmd(rq);
- rq->buffer = (char *) pc;
+ rq->special = pc;
rq->bh = idescsi_dma_bh(drive, pc);
rq->cmd = IDESCSI_PC_RQ;
spin_unlock_irq(&io_request_lock);
next prev parent reply other threads:[~2003-04-21 19:46 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-21 18:47 Linux 2.4.21-rc1 Marcelo Tosatti
2003-04-21 19:58 ` Stephan von Krawczynski [this message]
2003-04-21 22:49 ` Ben Greear
2003-04-21 23:24 ` Willy Tarreau
2003-04-21 23:10 ` J.A. Magallon
2003-04-21 23:39 ` Linux 2.4.21-rc1 - unresolved Eyal Lebedinsky
2003-04-22 7:15 ` Marc-Christian Petersen
2003-04-23 19:44 ` Bill Davidsen
2003-04-23 19:51 ` Marcelo Tosatti
2003-04-24 11:27 ` Marc-Christian Petersen
2003-04-24 11:32 ` Marc-Christian Petersen
2003-04-24 11:37 ` Christoph Hellwig
2003-05-06 2:48 ` Mike Fedyk
2003-04-22 3:00 ` Linux 2.4.21-rc1 Corey Minyard
2003-04-22 21:49 ` Marcelo Tosatti
2003-04-22 22:54 ` Corey Minyard
2003-04-22 13:42 ` Geert Uytterhoeven
2003-04-22 17:09 ` Rene Rebe
2003-04-22 19:15 ` Lukasz Trabinski
2003-04-22 22:59 ` J.A. Magallon
2003-04-23 7:59 ` IEEE-1394 problem on init [ was Re: Linux 2.4.21-rc1 ] Stelian Pop
2003-04-23 8:08 ` Linux 2.4.21-rc1 Jerome Chantelauze
2003-04-23 15:09 ` Athanasius
2003-04-23 20:46 ` Olaf Hering
2003-04-30 21:30 ` Carl-Daniel Hailfinger
2003-04-25 3:06 ` Lucas Correia Villa Real
2003-06-07 19:35 ` Adrian Bunk
2003-06-11 4:27 ` Lucas Correia Villa Real
2003-04-25 3:13 ` Lucas Correia Villa Real
2003-04-25 14:15 ` Andreas Metzler
2003-04-25 14:27 ` Martin Josefsson
2003-04-25 14:46 ` Andreas Metzler
2003-04-25 16:19 ` Zed Pobre
2003-04-25 16:24 ` Marc-Christian Petersen
2003-05-06 2:57 ` Mike Fedyk
[not found] <cistron.Pine.LNX.4.53L.0304211545580.12940@freak.distro.conectiva>
[not found] ` <E198M48-0000tC-00@ncc1701.cistron.net>
2003-04-23 15:36 ` Athanasius
2003-04-23 16:40 ` Athanasius
2003-04-25 16:17 ` Bill Davidsen
2003-04-25 20:30 ` Athanasius
2003-05-06 4:30 ` Mike Fedyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030421215824.5f5cec7e.skraw@ithnet.com \
--to=skraw@ithnet.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).