linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stelian Pop <stelian.pop@fr.alcove.com>
To: Ben Collins <bcollins@debian.org>
Cc: Tony Spinillo <tspinillo@yahoo.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: IEEE-1394 problem on init [ was Re: Linux 2.4.21-rc1 ]
Date: Wed, 23 Apr 2003 15:58:14 +0200	[thread overview]
Message-ID: <20030423135814.GJ820@hottah.alcove-fr> (raw)
In-Reply-To: <20030423133256.GG354@phunnypharm.org>

On Wed, Apr 23, 2003 at 09:32:56AM -0400, Ben Collins wrote:

> > Can we see it please ?
> 
> Stelia,
> 
> http://www.linux1394.org/viewcvs/ieee1394/branches/linux-2.4
> 
> Click the "Download tarball" link and replace drivers/ieee1394 with what
> you get.

Hey, that's a whole new version of ieee1394 subsystem, see below the
diffstat.

There is *NO WAY* Marcelo will accept such a patch in the -rc stage.

>From a quick reading, your version seem to do exactly the same thing
that my patch suggested (removing the spinlock around kernel_thread()),
possibly with the locking being moved to the upper layer.

Do you have a stripped down patch correcting only the outstanding issues ?
If you haven't, the choice will be either accepting my patch or 
reverting your entire ieee1394 changes for the time being.

Stelian.


 amdtp.c                 |   78 ++--
 cmp.c                   |   70 ---
 csr.c                   |   14 
 dv1394-private.h        |    2 
 dv1394.c                |   12 
 eth1394.c               |  110 +-----
 eth1394.h               |    1 
 highlevel.c             |  247 +++++++++++--
 highlevel.h             |   26 +
 hosts.c                 |   68 +--
 hosts.h                 |   21 -
 ieee1394-ioctl.h        |    4 
 ieee1394.h              |   10 
 ieee1394_core.c         |  232 +++++++++---
 ieee1394_core.h         |   15 
 ieee1394_hotplug.h      |    2 
 ieee1394_transactions.c |  473 ++++++++++---------------
 ieee1394_transactions.h |   57 ---
 ieee1394_types.h        |   26 +
 nodemgr.c               |  344 +++++++++---------
 nodemgr.h               |   23 -
 ohci1394.c              |   37 --
 pcilynx.c               |  119 +++++-
 raw1394-private.h       |    1 
 raw1394.c               |  151 +++-----
 sbp2.c                  |  875 +++++++++++++++++-------------------------------
 sbp2.h                  |  149 ++------
 video1394.c             |  136 ++-----
 video1394.h             |    1 
 29 files changed, 1562 insertions(+), 1742 deletions(-)


-- 
Stelian Pop <stelian.pop@fr.alcove.com>
Alcove - http://www.alcove.com

  parent reply	other threads:[~2003-04-23 13:46 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-23 12:29 IEEE-1394 problem on init [ was Re: Linux 2.4.21-rc1 ] Tony Spinillo
2003-04-23 12:53 ` Stelian Pop
2003-04-23 13:01   ` Ben Collins
2003-04-23 13:22     ` Stelian Pop
2003-04-23 13:32       ` Ben Collins
2003-04-23 13:46         ` Ben Collins
2003-04-23 13:58         ` Stelian Pop [this message]
2003-04-23 13:54           ` Ben Collins
2003-04-23 14:21             ` Stelian Pop
2003-04-23 14:23               ` Ben Collins
2003-04-23 14:51                 ` Stelian Pop
2003-04-23 14:44                   ` Ben Collins
2003-04-23 14:48                   ` Ben Collins
2003-04-23 15:29                     ` Stelian Pop
2003-04-23 19:13                       ` Marcelo Tosatti
2003-04-23 19:05                         ` Ben Collins
2003-04-23 19:27                           ` Marcelo Tosatti
2003-04-23 20:20                         ` Stelian Pop
2003-04-23 20:24                           ` Ben Collins
2003-04-23 20:42                             ` Stelian Pop
2003-04-26  8:29                               ` The IEEE-1394 saga continued... [ was: IEEE-1394 problem on init ] Stelian Pop
2003-04-26 14:34                                 ` Ben Collins
2003-04-26 16:10                                   ` Stelian Pop
2003-04-26 16:12                                     ` Ben Collins
2003-04-26 17:00                                       ` Stelian Pop
2003-04-26 16:59                                         ` Ben Collins
2003-04-26 14:40                                 ` Ben Collins
2003-04-26 16:23                                   ` Stelian Pop
2003-04-26 16:25                                     ` Ben Collins
2003-04-26 17:15                                       ` Stelian Pop
2003-04-24 21:44                         ` IEEE-1394 problem on init [ was Re: Linux 2.4.21-rc1 ] Bill Davidsen
2003-04-24 21:41                           ` Ben Collins
2003-04-25 18:06                             ` Bill Davidsen
2003-04-25 18:16                               ` Ben Collins
2003-04-26 10:36                                 ` Bill Davidsen
  -- strict thread matches above, loose matches on Subject: below --
2003-04-21 18:47 Linux 2.4.21-rc1 Marcelo Tosatti
2003-04-23  7:59 ` IEEE-1394 problem on init [ was Re: Linux 2.4.21-rc1 ] Stelian Pop

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030423135814.GJ820@hottah.alcove-fr \
    --to=stelian.pop@fr.alcove.com \
    --cc=bcollins@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tspinillo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).