From: Chuck Ebbert <76306.1226@compuserve.com>
To: Jens Axboe <axboe@suse.de>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] 2.4.21-rc1 pointless IDE noise reduction
Date: Thu, 24 Apr 2003 11:25:08 -0400 [thread overview]
Message-ID: <200304241128_MC3-1-35DA-F3DA@compuserve.com> (raw)
Jens Axboe wrote:
>> + return((drive->id->cfs_enable_1 & 0x0400) ? 1 : 0);
>> }
>
> Seconded, it causes a lot more confusion than it does good.
The return looks like a function call in that last line.
That's one of the few things I find really annoying -- extra parens
are fine when they make code clearer, but not there.
-------
Chuck [ C Style Police, badge #666 ]
next reply other threads:[~2003-04-24 15:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-24 15:25 Chuck Ebbert [this message]
2003-04-24 15:59 ` [PATCH] 2.4.21-rc1 pointless IDE noise reduction Richard B. Johnson
2003-04-24 16:31 ` Timothy Miller
2003-04-24 16:46 ` Richard B. Johnson
2003-04-24 17:15 ` Timothy Miller
2003-04-24 18:27 ` Willy Tarreau
2003-04-24 19:00 ` Timothy Miller
2003-04-25 18:14 ` Bill Davidsen
2003-04-25 18:30 ` Richard B. Johnson
-- strict thread matches above, loose matches on Subject: below --
2003-04-24 23:25 Chuck Ebbert
2003-04-25 15:08 ` Timothy Miller
2003-04-24 9:34 Erik Andersen
2003-04-24 10:28 ` Jens Axboe
2003-04-27 12:21 ` Adrian Bunk
2003-04-27 17:44 ` Erik Andersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200304241128_MC3-1-35DA-F3DA@compuserve.com \
--to=76306.1226@compuserve.com \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).