From: Pavel Machek <pavel@suse.cz>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, acpi-support@lists.sourceforge.net,
Scott Feldman <scott.feldman@intel.com>
Subject: Re: [2.5.75] S3 and S4
Date: Sat, 12 Jul 2003 15:54:53 +0200 [thread overview]
Message-ID: <20030712135452.GA284@elf.ucw.cz> (raw)
In-Reply-To: <20030711145309.091069e6.akpm@osdl.org>
Hi!
> > > > > Suspending devices
> > > > > Badness in local_bh_enable at kernel/softirq.c:113
> > > > > Call Trace:
> > > > > [<c0130078>] local_bh_enable+0x88/0x90
> > > > > [<f0a44fa4>] e100_do_wol+0x14/0x60 [e100]
> > > > > [<f0a461ee>] e100_suspend+0x3e/0xa0 [e100]
> > > > > [<f0a461b0>] e100_suspend+0x0/0xa0 [e100]
> > > > > [<c0212577>] pci_device_suspend+0x47/0x70
> > > > > [<c029bc99>] device_suspend+0xd9/0x100
> > > > > [<c023e047>] acpi_system_save_state+0x42/0x8c
> > > > > [<c023e153>] acpi_suspend+0x5e/0xb3
> > > > > [<c023e394>] acpi_system_write_sleep+0xe3/0x132
> > > > > [<c0177de0>] filp_open+0x60/0x70
> > > > > [<c017952d>] vfs_write+0xad/0x120
> > > > > [<c017963f>] sys_write+0x3f/0x60
> > > > > [<c010b10f>] syscall_call+0x7/0xb
> > > > >
> > > >
> > > > If e100. You have the hardware...
> > >
> > > No, it's acpi_system_save_state() illegally calling device_suspend() under
> > > local_irq_disable().
> >
> > Oops, I failed to see this is S3.
> >
> > I can see that device_suspend( ..., SUSPEND_POWER_DOWN) is called with
> > interrupts disabled. But thats okay: (driver.txt) All calls are made
> > with interrupts enabled, except for the SUSPEND_POWER_DOWN level.
>
> OK, it's an e100 bug then. Not allowed to sleep or do spin_unloch_bh() in
> device_suspend( ..., SUSPEND_POWER_DOWN).
>
> That's a fairly awkward restriction.
Actually, its not. Some phase with interrupts off is needed for
devices such as interrupt controller. Fix is very simple: move the
e100 suspend from SUSPEND_POWER_DOWN to some other level.
Pavel
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
next prev parent reply other threads:[~2003-07-12 13:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-11 19:36 [2.5.75] S3 and S4 Kronos
2003-07-11 20:00 ` Pavel Machek
2003-07-11 20:45 ` Pavel Machek
2003-07-11 20:48 ` Andrew Morton
2003-07-11 21:52 ` Pavel Machek
2003-07-11 21:53 ` Andrew Morton
2003-07-12 13:54 ` Pavel Machek [this message]
2003-07-12 16:45 ` [ACPI-sppt] " Kronos
2003-07-12 20:12 ` Pavel Machek
2003-07-17 19:09 ` Kronos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030712135452.GA284@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=acpi-support@lists.sourceforge.net \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=scott.feldman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).