From: Andrew Morton <akpm@osdl.org>
To: Con Kolivas <kernel@kolivas.org>
Cc: linux-kernel@vger.kernel.org, efault@gmx.de, felipe_alfaro@linuxmail.org
Subject: Re: [PATCH] N1int for interactivity
Date: Mon, 14 Jul 2003 20:59:15 -0700 [thread overview]
Message-ID: <20030714205915.5a4c8d16.akpm@osdl.org> (raw)
In-Reply-To: <200307151355.23586.kernel@kolivas.org>
Con Kolivas <kernel@kolivas.org> wrote:
>
> I've modified Mike Galbraith's nanosleep work for greater resolution to help
> the interactivity estimator work I've done in the O*int patches.
> +inline void __scheduler_tick(runqueue_t *rq, task_t *p)
Two callsites, this guy shouldn't be inlined.
Should it have static scope? The code as-is generates a third copy...
> static unsigned long long monotonic_clock_tsc(void)
> {
> unsigned long long last_offset, this_offset, base;
> -
> + unsigned long flags;
> +
> /* atomically read monotonic base & last_offset */
> - read_lock_irq(&monotonic_lock);
> + read_lock_irqsave(&monotonic_lock, flags);
> last_offset = ((unsigned long long)last_tsc_high<<32)|last_tsc_low;
> base = monotonic_base;
> - read_unlock_irq(&monotonic_lock);
> + read_unlock_irqrestore(&monotonic_lock, flags);
>
> /* Read the Time Stamp Counter */
Why do we need to take a global lock here? Can't we use
get_cycles() or something?
Have all the other architectures been reviewed to see if they need this
change?
next prev parent reply other threads:[~2003-07-15 3:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-15 3:55 [PATCH] N1int for interactivity Con Kolivas
2003-07-15 3:59 ` Andrew Morton [this message]
2003-07-15 4:03 ` Con Kolivas
2003-07-15 7:02 ` Mike Galbraith
2003-07-15 7:00 ` Zwane Mwaikambo
2003-07-15 10:23 ` Con Kolivas
2003-07-15 15:23 ` Felipe Alfaro Solana
2003-07-15 23:12 ` Con Kolivas
2003-07-16 7:12 ` Felipe Alfaro Solana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030714205915.5a4c8d16.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=efault@gmx.de \
--cc=felipe_alfaro@linuxmail.org \
--cc=kernel@kolivas.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).