linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Norbert Preining <preining@logic.at>
Cc: gaxt@rogers.com, henrik@fangorn.dk, romieu@fr.zoreil.com,
	linux-kernel@vger.kernel.org, felipe_alfaro@linuxmail.org,
	babydr@baby-dragons.com, len.brown@intel.com
Subject: Re: 2.6.0-test3 cannot mount root fs
Date: Sun, 10 Aug 2003 15:43:43 -0700	[thread overview]
Message-ID: <20030810154343.351aa69d.akpm@osdl.org> (raw)
In-Reply-To: <20030810211745.GA5327@gamma.logic.tuwien.ac.at>

Norbert Preining <preining@logic.at> wrote:
>
> I tried as boot cmd line:
>  	s root=03:41 acpi=off
>  and still it didn't work. Same problem.

It is decimal.  You want 03:65.


Could you test this patch?  It should put things back to the way
they were before this mini-fisaco. root=0341 should work as well.


 init/do_mounts.c |   18 ++++++++++++------
 1 files changed, 12 insertions(+), 6 deletions(-)

diff -puN init/do_mounts.c~handle-old-dev_t-format init/do_mounts.c
--- 25/init/do_mounts.c~handle-old-dev_t-format	2003-08-09 16:15:24.000000000 -0700
+++ 25-akpm/init/do_mounts.c	2003-08-09 16:17:25.000000000 -0700
@@ -71,13 +71,19 @@ static dev_t __init try_name(char *name,
 	if (len <= 0 || len == 32 || buf[len - 1] != '\n')
 		goto fail;
 	buf[len - 1] = '\0';
-	/*
-	 * The format of dev is now %u:%u -- see print_dev_t()
-	 */
-	if (sscanf(buf, "%u:%u", &maj, &min) == 2)
+	if (sscanf(buf, "%u:%u", &maj, &min) == 2) {
+		/*
+		 * Try the %u:%u format -- see print_dev_t()
+		 */
 		res = MKDEV(maj, min);
-	else
-		goto fail;
+	} else {
+		/*
+		 * Nope.  Try old-style "0321"
+		 */
+		res = (dev_t)simple_strtoul(buf, &s, 16);
+		if (*s)
+			goto fail;
+	}
 
 	/* if it's there and we are not looking for a partition - that's it */
 	if (!part)

_


  reply	other threads:[~2003-08-10 22:45 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-09 10:46 2.6.0-test3 cannot mount root fs gaxt
2003-08-09 10:40 ` Norbert Preining
2003-08-09 11:56   ` Herbert Pötzl
2003-08-09  9:07     ` Norbert Preining
     [not found]       ` <20030809130641.A8174@electric-eye.fr.zoreil.com>
     [not found]         ` <01a201c35e65$0536ef60$ee52a450@theoden>
2003-08-09 11:58   ` Henrik Storner
2003-08-09 13:48   ` Felipe Alfaro Solana
2003-08-09 14:32 ` Mr. James W. Laferriere
2003-08-09 14:48   ` gaxt
2003-08-09 14:38     ` Mr. James W. Laferriere
2003-08-09 15:19       ` DVD Problems 2.6.0-test3 & 2.6.0-test2-mm5 gaxt
2003-08-09 15:01     ` 2.6.0-test3 cannot mount root fs Henrik Ræder Clausen
2003-08-10 21:17   ` Norbert Preining
2003-08-10 22:43     ` Andrew Morton [this message]
2003-08-11  5:34       ` Norbert Preining
2003-08-11 14:59         ` Herbert Pötzl
2003-08-11 15:40           ` Norbert Preining
2003-08-11 18:53             ` Herbert Pötzl
2003-08-11 21:50               ` Norbert Preining
2003-08-11 22:21                 ` Herbert Pötzl
2003-08-12  1:52                   ` Mark W. Alexander
2003-08-12  6:28                     ` Norbert Preining
2003-08-12  5:39                   ` Norbert Preining
2003-08-12 12:26                     ` Herbert Pötzl
2003-08-12 12:31                       ` Norbert Preining
2003-08-12 12:44                       ` jeff millar
2003-08-12 23:52                         ` Thomas Molina
2003-08-13 16:59                           ` Paul Dickson
2003-08-14  4:09                             ` jeff millar
2003-08-13  6:15   ` SOLUTION " Norbert Preining
2003-08-13  6:27     ` "Andrey Borzenkov" 
2003-08-13  6:30       ` Norbert Preining
2003-08-13 12:07     ` jeff millar
2003-08-13 12:30       ` Herbert Pötzl
     [not found]         ` <00bb01c36198$51cba650$6401a8c0@wa1hco>
2003-08-13 13:24           ` Herbert Pötzl
     [not found]             ` <009b01c362d5$13838b90$6401a8c0@wa1hco>
     [not found]               ` <20030815030013.GA9587@www.13thfloor.at>
     [not found]                 ` <00a401c3632a$80dd2a20$6401a8c0@wa1hco>
     [not found]                   ` <20030815132619.GB3695@www.13thfloor.at>
2003-08-16  0:34                     ` 2.6.0-test3 _still_ " jeff millar
2003-08-16 15:00                       ` Herbert Pötzl
2003-08-13 13:24     ` SOLUTION Re: 2.6.0-test3 " Christian Mautner
2003-08-12  7:37 Daniel Blueman
2003-08-12 13:22 "Andrey Borzenkov" 
2003-08-12 14:06 ` Herbert Pötzl
2003-08-12 14:21   ` Christophe Saout
2003-08-12 13:23 "Andrey Borzenkov" 
2003-08-12 20:43 ` Norbert Preining
2003-08-13  5:17   ` "Andrey Borzenkov" 
2003-08-12 14:16 "Andrey Borzenkov" 

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030810154343.351aa69d.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=babydr@baby-dragons.com \
    --cc=felipe_alfaro@linuxmail.org \
    --cc=gaxt@rogers.com \
    --cc=henrik@fangorn.dk \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=preining@logic.at \
    --cc=romieu@fr.zoreil.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).