From: Francois Romieu <romieu@fr.zoreil.com>
To: Ronald Bultje <rbultje@ronald.bitfreak.net>
Cc: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@odsl.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] 2.6.0-test3 zoran driver update
Date: Thu, 21 Aug 2003 01:08:12 +0200 [thread overview]
Message-ID: <20030821010812.A6961@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <1061414594.1320.97.camel@localhost.localdomain>; from rbultje@ronald.bitfreak.net on Wed, Aug 20, 2003 at 11:23:15PM +0200
Ronald Bultje <rbultje@ronald.bitfreak.net> :
[...]
- {adv7170/adv7175/bt819/saa7110/saa7185}_detect_client()
for each of these functions, two error exit path leak on locally allocated
variable "channel".
- {adv7170/adv7175/bt819/saa7111/saa7185}_write_block()
The code duplication could surely be avoided.
- always put a blank line between variables declaration and code pleae
- find_zr36057():
what about replacing pci_find_device() by the modern pci insertion/removal
api (which has been standing there for ~3 years)
- pci_enable_device() in find_zr36057() isn't balanced by pci_disable_device()
in zoran_release()
- +irqreturn_t
+zoran_irq (int irq,
[...]
+ for (i = 0; i < 4; i++) {
+ if (zr->
+ stat_com[i] &
+ 1)
+ sv[i] =
+ '1';
+ }
Post-modernism ?
It looks interesting.
--
Ueimor
next prev parent reply other threads:[~2003-08-20 23:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-20 21:23 [PATCH] 2.6.0-test3 zoran driver update Ronald Bultje
2003-08-20 23:08 ` Francois Romieu [this message]
2003-08-21 7:47 ` Ronald Bultje
2003-08-21 11:01 ` Francois Romieu
2003-08-21 11:40 ` Ronald Bultje
2003-08-24 4:23 ` Ronald Bultje
2003-08-24 11:32 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030821010812.A6961@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rbultje@ronald.bitfreak.net \
--cc=torvalds@odsl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).