From: Anton Blanchard <anton@samba.org>
To: linux-kernel@vger.kernel.org
Subject: Re: Race condition in 2.4 tasklet handling
Date: Sun, 24 Aug 2003 01:04:13 +1000 [thread overview]
Message-ID: <20030823150413.GA32537@krispykreme> (raw)
In-Reply-To: <20030823025448.GA32547@atj.dyndns.org>
Hi,
> Adding smp_mb__after_test_and_set_bit() at the end of
> tasklet_trylock() should remedy the situation. As
> smp_mb__{before|after}_test_and_set_bit() don't exist yet, I'm
> attaching a patch which adds smp_mb__after_clear_bit(). The patch is
> against 2.4.21.
No, the atomic and bitop operations that return values (like
test_and_set_bit) must have barriers. Is x86 missing these?
> P.S. Please comment on the addition of
> smp_mb__{before|after}_test_and_set_bit().
Only the atomic and bitops that dont return values (set_bit, atomic_inc
etc) might require ordering depending on use.
Anton
prev parent reply other threads:[~2003-08-23 17:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-23 2:54 Race condition in 2.4 tasklet handling TeJun Huh
2003-08-23 4:09 ` Race condition in 2.4 tasklet handling (cli() broken?) TeJun Huh
2003-08-23 5:26 ` TeJun Huh
2003-08-23 10:28 ` Stephan von Krawczynski
2003-08-23 15:13 ` TeJun Huh
2003-08-23 15:37 ` Stephan von Krawczynski
2003-08-25 6:31 ` TeJun Huh
2003-08-25 7:23 ` Stephan von Krawczynski
2003-08-26 0:27 ` TeJun Huh
2003-08-23 15:56 ` Stephan von Krawczynski
2003-08-23 16:36 ` TeJun Huh
2003-08-24 3:27 ` TeJun Huh
2003-08-23 15:04 ` Anton Blanchard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030823150413.GA32537@krispykreme \
--to=anton@samba.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).