From: Con Kolivas <kernel@kolivas.org>
To: Nick Piggin <piggin@cyberone.com.au>,
Thomas Schlichter <schlicht@uni-mannheim.de>
Cc: linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH]O18.1int
Date: Sat, 23 Aug 2003 22:22:30 +1000 [thread overview]
Message-ID: <200308232222.30527.kernel@kolivas.org> (raw)
In-Reply-To: <3F47317D.3030802@cyberone.com.au>
On Sat, 23 Aug 2003 19:18, Nick Piggin wrote:
> Hi
> I don't know what is preferred on lkml, but I dislike mixing booleans
> and integer arithmetic.
>
> if (!LOW_CREDIT(prev))
> prev->interactive_credit--;
>
> Easier to read IMO.
I agree. I only mixed them because of my (perhaps false) belief that it's less
of a hit not having another if.. branch point. Then again today's compilers
probably optimise it out anyway.
Con
next prev parent reply other threads:[~2003-08-23 12:18 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-23 5:55 [PATCH]O18.1int Con Kolivas
2003-08-23 9:08 ` [PATCH]O18.1int Thomas Schlichter
2003-08-23 9:18 ` [PATCH]O18.1int Nick Piggin
2003-08-23 12:22 ` Con Kolivas [this message]
2003-08-23 12:21 ` [PATCH]O18.1int Con Kolivas
2003-08-23 9:32 ` [PATCH]O18.1int Andrew Morton
2003-08-23 9:49 ` [PATCH]O18.1int Nick Piggin
2003-08-23 16:58 ` [PATCH]O18.1int Con Kolivas
2003-08-23 21:49 ` [PATCH]O18.1int Andrew Morton
2003-08-24 2:46 ` [PATCH]O18.1int Con Kolivas
2003-08-23 13:29 ` [PATCH]O18.1int Con Kolivas
2003-08-25 9:24 ` [PATCH]O18.1int Måns Rullgård
2003-08-25 9:42 ` [PATCH]O18.1int Alex Riesen
2003-08-25 10:16 ` [PATCH]O18.1int Con Kolivas
2003-08-25 10:21 ` [PATCH]O18.1int Alex Riesen
2003-08-25 21:02 ` [PATCH]O18.1int Alex Riesen
2003-08-25 22:48 ` [PATCH]O18.1int Con Kolivas
2003-08-25 23:00 ` [PATCH]O18.1int Alex Riesen
2003-08-26 22:03 ` [PATCH]O18.1int Alex Riesen
2003-08-25 10:34 ` [PATCH]O18.1int Måns Rullgård
2003-08-25 10:50 ` [PATCH]O18.1int Con Kolivas
2003-08-25 11:15 ` [PATCH]O18.1int Måns Rullgård
2003-08-25 11:37 ` [PATCH]O18.1int Con Kolivas
2003-08-25 11:58 ` [PATCH]O18.1int Måns Rullgård
2003-08-25 12:28 ` [PATCH]O18.1int Con Kolivas
2003-08-25 12:49 ` [PATCH]O18.1int Måns Rullgård
2003-08-25 13:32 ` [PATCH]O18.1int Con Kolivas
2003-08-25 10:17 ` [PATCH]O18.1int Måns Rullgård
2003-08-25 10:34 ` [PATCH]O18.1int Alex Riesen
2003-08-25 11:23 ` [PATCH]O18.1int Måns Rullgård
2003-08-25 10:48 ` [PATCH]O18.1int Con Kolivas
[not found] ` <3F49E482.7030902@cyberone.com.au>
[not found] ` <20030825102933.GA14552@Synopsys.COM>
2003-08-26 22:20 ` [PATCH]O18.1int Alex Riesen
2003-08-27 2:26 ` [PATCH]O18.1int Nick Piggin
2003-08-23 22:03 [PATCH]O18.1int Voluspa
2003-08-24 4:04 ` [PATCH]O18.1int Con Kolivas
2003-08-28 12:23 [PATCH]O18.1int Guillaume Chazarain
2003-08-28 13:43 [PATCH]O18.1int Guillaume Chazarain
2003-08-28 13:58 ` [PATCH]O18.1int Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200308232222.30527.kernel@kolivas.org \
--to=kernel@kolivas.org \
--cc=linux-kernel@vger.kernel.org \
--cc=piggin@cyberone.com.au \
--cc=schlicht@uni-mannheim.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).