From: Misha Nasledov <misha@nasledov.com>
To: Felipe Alfaro Solana <felipe_alfaro@linuxmail.org>
Cc: Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>
Subject: Re: APM Suspend Problem
Date: Thu, 27 Nov 2003 12:22:45 -0800 [thread overview]
Message-ID: <20031127202245.GA3892@nasledov.com> (raw)
In-Reply-To: <1069933566.2144.1.camel@teapot.felipe-alfaro.com>
No luck; my ThinkPad still does not go into the proper power-saving mode. The LCD
blanks out and the HD spins down, but it is not a real sleep mode.
On Thu, Nov 27, 2003 at 12:46:06PM +0100, Felipe Alfaro Solana wrote:
> On Thu, 2003-11-27 at 07:20, Misha Nasledov wrote:
> > Since about 2.6.0-test9, my ThinkPad T21 no longer suspends with APM. I had
> > issues with it suspending before, I don't remember exactly what issues, but I
> > know that it definitely worked in -test2. When I hit the key on my laptop to
> > suspend, it will turn off the LCD and the HD will spin down, but the machine
> > will not actually suspend. Here is what is printed out on the console when I
> > hit the suspend key and then when I hit another key to "wake" it up:
>
> Could you please try the attached patch? It allows my system to suspend
> and resume using APM flawlessly.
> --- 1.11/drivers/base/power/resume.c Mon Aug 25 11:08:21 2003
> +++ edited/drivers/base/power/resume.c Fri Oct 10 21:06:07 2003
> @@ -22,8 +22,17 @@
>
> int resume_device(struct device * dev)
> {
> - if (dev->bus && dev->bus->resume)
> - return dev->bus->resume(dev);
> + if (dev->bus && dev->bus->resume) {
> + int retval;
> +
> + /* drop lock so the call can use device_del() to clean up
> + * after unplugged (or otherwise vanished) child devices
> + */
> + up(&dpm_sem);
> + retval = dev->bus->resume(dev);
> + down(&dpm_sem);
> + return retval;
> + }
> return 0;
> }
--
Misha Nasledov
misha@nasledov.com
http://nasledov.com/misha/
next prev parent reply other threads:[~2003-11-27 20:24 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-27 6:20 APM Suspend Problem Misha Nasledov
2003-11-27 11:46 ` Felipe Alfaro Solana
2003-11-27 20:22 ` Misha Nasledov [this message]
2003-11-27 22:58 ` Benjamin Herrenschmidt
2003-11-27 23:33 ` Misha Nasledov
2003-11-28 21:28 ` William Lee Irwin III
2003-11-28 21:50 ` Misha Nasledov
2003-11-28 21:50 ` William Lee Irwin III
2003-11-28 22:27 ` Nigel Cunningham
2003-11-28 22:49 ` William Lee Irwin III
2003-11-29 2:17 ` Misha Nasledov
2003-11-29 2:20 ` William Lee Irwin III
2003-11-29 2:35 ` Nigel Cunningham
2003-11-29 5:38 ` Shawn Willden
2003-11-29 5:46 ` William Lee Irwin III
2003-11-29 9:57 ` Misha Nasledov
2003-11-29 7:36 ` Misha Nasledov
2003-12-01 20:24 ` Pavel Machek
2003-12-02 21:44 ` john stultz
[not found] <WnPi.57n.5@gated-at.bofh.it>
[not found] ` <WsPg.Xi.35@gated-at.bofh.it>
[not found] ` <WAWd.BP.7@gated-at.bofh.it>
2003-11-28 21:12 ` Michael Schierl
2003-11-29 1:02 pZa1x
2003-11-29 1:14 ` pZa1x
2003-11-29 8:22 ` Russell King
2003-11-29 11:26 ` pZa1x
2003-12-01 21:07 ` Russell King
2003-12-06 21:46 ` pZa1x
2003-12-07 17:06 ` Russell King
[not found] <15Eea-Id-23@gated-at.bofh.it>
[not found] ` <15Eea-Id-25@gated-at.bofh.it>
[not found] ` <15Eea-Id-27@gated-at.bofh.it>
[not found] ` <15Eea-Id-21@gated-at.bofh.it>
2003-12-25 19:17 ` Michael Schierl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031127202245.GA3892@nasledov.com \
--to=misha@nasledov.com \
--cc=felipe_alfaro@linuxmail.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).