From: Ingo Oeser <ioe-lkml@rameria.de>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Timo Kamph <timo@kamph.org>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
netdev@oss.sgi.com, davem@redhat.com
Subject: Re: [PATCH 2.6]: IPv4: strcpy -> strlcpy
Date: Sun, 30 Nov 2003 11:26:22 +0100 [thread overview]
Message-ID: <200311301126.24035.ioe-lkml@rameria.de> (raw)
In-Reply-To: <1070012538.10048.13.camel@hades.cambridge.redhat.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Friday 28 November 2003 10:42, David Woodhouse wrote:
> On Thu, 2003-11-27 at 23:09 +0100, Felipe Alfaro Solana wrote:
> > On Thu, 2003-11-27 at 21:48, Timo Kamph wrote:
> > > > + strlcpy(label->label, name, sizeof(label->name));
> > >
> > >
> > > ^^^^^^ I guess this shoud be label->label, or am I wrong?
> >
> > Oh my god! Two consecutive mistakes with the same patch! I should have
> > some sleep... Here's the one with the typo corrected.
>
> Perhaps we should consider
>
> #define strsizecpy(x, y) strlcpy((x), (y), sizeof(x))
Then we should do:
#define strsizecpy(x, y) strlcpy(x, y, sizeof(x)/sizeof(x[0]))
to rule out passing the wrong variables or dereferencing to much.
Unfortunatly there is no simple way in C to differentiate between array and
pointer.
There is a way with typeof, but that is hackish.
Regards
Ingo Oeser
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)
iD8DBQE/ycXOU56oYWuOrkARAiJ8AJ9wkl1ijJVn5M+lGhUwSwWRxzxxHwCg2nAU
t+9HdAasQDZo/GQFuj9s5ZU=
=py/4
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2003-11-30 10:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-27 14:04 [PATCH 2.6]: IPv4: strcpy -> strlcpy Felipe Alfaro Solana
2003-11-27 14:21 ` David Roundy
2003-11-27 15:25 ` Felipe Alfaro Solana
2003-11-27 20:48 ` Timo Kamph
2003-11-27 22:09 ` Felipe Alfaro Solana
2003-11-28 2:05 ` YOSHIFUJI Hideaki / 吉藤英明
2003-11-28 9:42 ` David Woodhouse
2003-11-30 10:26 ` Ingo Oeser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200311301126.24035.ioe-lkml@rameria.de \
--to=ioe-lkml@rameria.de \
--cc=davem@redhat.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=timo@kamph.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).