From: Jens Axboe <axboe@suse.de>
To: Linus Torvalds <torvalds@osdl.org>
Cc: ross.alexander@uk.neceur.com, Ed Sweetman <ed.sweetman@wmich.edu>,
Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: IDE-SCSI oops in 2.6.0-test11
Date: Wed, 3 Dec 2003 10:06:04 +0100 [thread overview]
Message-ID: <20031203090604.GS12211@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.58.0312021028590.1519@home.osdl.org>
On Tue, Dec 02 2003, Linus Torvalds wrote:
>
>
> On Tue, 2 Dec 2003 ross.alexander@uk.neceur.com wrote:
> >
> > I can't get the source, otherwise I would have compiled it against
> > 2.6.0. However I don't find this point particularly relevant since
> > 2.6.0 should be backward compatible with 2.4,0, atleast at the binary
> > level.
> >
> > I tried the earlier versions of dvdrtools and cdrtools and their didn't
> > like ide-cd. This version (cdrecord-dvdpro) does but it still don't
> > alter the fact that while using ide-scsi is no longer recommended, it
> > still should work.
>
> Well, we're trying, but nobody has had a lot of luck with it.
>
> However, your particular case looks pretty straightforward:
>
> > Here the the oops again.
> >
> > Dec 2 12:02:46 mig27 kernel: Unable to handle kernel NULL pointer dereference at virtual address 00000000
> > Dec 2 12:02:46 mig27 kernel: printing eip:
> > Dec 2 12:02:46 mig27 kernel: 00000000
>
> Somebody jumped through a NULL pointer, and it was:
>
> > Dec 2 12:02:46 mig27 kernel: Process cdrecord-prodvd (pid: 369, threadinfo=e4160000 task=f65d4100)
> > Dec 2 12:02:46 mig27 kernel: Call Trace:
> > Dec 2 12:02:46 mig27 kernel: [<f9859b1b>] idescsi_transfer_pc+0x11b/0x120 [ide_scsi]
>
> That's the code that does:
>
> ...
> if (test_bit (PC_DMA_OK, &pc->flags)) {
> set_bit (PC_DMA_IN_PROGRESS, &pc->flags);
> (void) (HWIF(drive)->ide_dma_begin(drive));
> }
> ...
>
> and it looks like the PC_DMA_OK flag is incorrect.
>
> Doing a bit more digging shows that "idescsi_issue_pc()" seems to use some
> variables without ever actually _initializing_ them. How about this
> trivial one-liner? Does that make it work for you?
>
> Jens? Comments?
>
> Linus
>
> ---
> ===== drivers/scsi/ide-scsi.c 1.33 vs edited =====
> --- 1.33/drivers/scsi/ide-scsi.c Tue Nov 18 23:40:45 2003
> +++ edited/drivers/scsi/ide-scsi.c Tue Dec 2 10:36:33 2003
> @@ -516,6 +516,7 @@
> pc->actually_transferred=0; /* We haven't transferred any data yet */
> pc->current_position=pc->buffer;
> bcount.all = IDE_MIN(pc->request_transfer, 63 * 1024); /* Request to transfer the entire buffer at once */
> + feature.all = 0;
>
> if (drive->using_dma && rq->bio) {
> if (test_bit(PC_WRITING, &pc->flags))
Your fix is correct Linus, the very same bug was fixed in 2.4 recently
as well.
--
Jens Axboe
next prev parent reply other threads:[~2003-12-03 9:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-02 12:40 IDE-SCSI oops in 2.6.0-test11 ross.alexander
2003-12-02 13:26 ` Ed Sweetman
2003-12-02 14:08 ` ross.alexander
2003-12-02 16:53 ` Len Brown
2003-12-02 18:37 ` Linus Torvalds
2003-12-03 9:06 ` Jens Axboe [this message]
2003-12-03 12:25 ` ross.alexander
2003-12-03 16:07 ` bill davidsen
2003-12-02 21:39 ` bill davidsen
2003-12-02 21:53 ` Craig Bradney
2003-12-02 23:10 ` bill davidsen
[not found] ` <200312022310.SAA14384@gatekeeper.tmr.com>
2003-12-02 23:30 ` Craig Bradney
2003-12-02 23:33 ` bill davidsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031203090604.GS12211@suse.de \
--to=axboe@suse.de \
--cc=ed.sweetman@wmich.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=ross.alexander@uk.neceur.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).