From: Con Kolivas <kernel@kolivas.org>
To: William Lee Irwin III <wli@holomorphy.com>
Cc: Chris Vine <chris@cvine.freeserve.co.uk>,
Rik van Riel <riel@redhat.com>,
linux-kernel@vger.kernel.org,
"Martin J. Bligh" <mbligh@aracnet.com>
Subject: Re: 2.6.0-test9 - poor swap performance on low end machines
Date: Tue, 9 Dec 2003 01:23:31 +1100 [thread overview]
Message-ID: <200312090123.31895.kernel@kolivas.org> (raw)
In-Reply-To: <20031208135225.GT19856@holomorphy.com>
[-- Attachment #1: Type: text/plain, Size: 363 bytes --]
[snip original discussion thrashing swap on 2.6test with 32mb ram]
Chris
By an unusual coincidence I was looking into the patches that were supposed to
speed up application startup and noticed this one was merged. A brief
discussion with wli suggests this could cause thrashing problems on low
memory boxes so can you try this patch? Applies to test11.
Con
[-- Attachment #2: patch-backout-readahead --]
[-- Type: text/x-diff, Size: 495 bytes --]
--- linux-2.6.0-test11-base/mm/filemap.c 2003-11-24 22:18:56.000000000 +1100
+++ linux-2.6.0-test11-fremap/mm/filemap.c 2003-12-09 01:17:47.793384425 +1100
@@ -1285,10 +1285,6 @@ static int filemap_populate(struct vm_ar
struct page *page;
int err;
- if (!nonblock)
- force_page_cache_readahead(mapping, vma->vm_file,
- pgoff, len >> PAGE_CACHE_SHIFT);
-
repeat:
size = (i_size_read(inode) + PAGE_CACHE_SIZE - 1) >> PAGE_CACHE_SHIFT;
if (pgoff + (len >> PAGE_CACHE_SHIFT) > size)
next prev parent reply other threads:[~2003-12-08 14:23 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-29 22:30 2.6.0-test9 - poor swap performance on low end machines Chris Vine
2003-10-31 3:57 ` Rik van Riel
2003-10-31 11:26 ` Roger Luethi
2003-10-31 12:37 ` Con Kolivas
2003-10-31 12:59 ` Roger Luethi
2003-10-31 12:55 ` Ed Tomlinson
2003-11-01 18:34 ` Pasi Savolainen
2003-11-06 18:40 ` bill davidsen
2003-10-31 21:52 ` Chris Vine
2003-11-02 23:06 ` Chris Vine
2003-11-03 0:48 ` Con Kolivas
2003-11-03 21:13 ` Chris Vine
2003-11-04 2:55 ` Con Kolivas
2003-11-04 22:08 ` Chris Vine
2003-11-04 22:30 ` Con Kolivas
2003-12-08 13:52 ` William Lee Irwin III
2003-12-08 14:23 ` Con Kolivas [this message]
2003-12-08 14:30 ` William Lee Irwin III
2003-12-09 21:03 ` Chris Vine
2003-12-13 14:08 ` Chris Vine
2003-12-08 19:49 ` Roger Luethi
2003-12-08 20:48 ` William Lee Irwin III
2003-12-09 0:27 ` Roger Luethi
2003-12-09 4:05 ` William Lee Irwin III
2003-12-09 15:11 ` Roger Luethi
2003-12-09 16:04 ` Rik van Riel
2003-12-09 16:31 ` Roger Luethi
2003-12-09 18:31 ` William Lee Irwin III
2003-12-09 19:38 ` William Lee Irwin III
2003-12-10 13:58 ` Roger Luethi
2003-12-10 17:47 ` William Lee Irwin III
2003-12-10 22:23 ` Roger Luethi
2003-12-11 0:12 ` William Lee Irwin III
2003-12-10 21:04 ` Rik van Riel
2003-12-10 23:17 ` Roger Luethi
2003-12-11 1:31 ` Rik van Riel
2003-12-11 10:16 ` Roger Luethi
2003-12-10 23:30 ` Helge Hafting
2003-12-10 21:52 ` Andrea Arcangeli
2003-12-10 22:05 ` Roger Luethi
2003-12-10 22:44 ` Andrea Arcangeli
2003-12-11 1:28 ` William Lee Irwin III
2003-12-11 1:32 ` Rik van Riel
2003-12-11 10:16 ` Roger Luethi
2003-12-15 23:31 ` Andrew Morton
2003-12-15 23:37 ` Andrea Arcangeli
2003-12-15 23:54 ` Andrew Morton
2003-12-16 0:17 ` Rik van Riel
2003-12-16 11:23 ` Roger Luethi
2003-12-16 16:29 ` Rik van Riel
2003-12-17 11:03 ` Roger Luethi
2003-12-17 11:06 ` William Lee Irwin III
2003-12-17 16:50 ` Roger Luethi
2003-12-17 11:33 ` Rik van Riel
2003-12-17 18:53 ` Rik van Riel
2003-12-17 19:27 ` William Lee Irwin III
2003-12-17 19:51 ` Rik van Riel
2003-12-17 19:49 ` Roger Luethi
2003-12-17 21:41 ` Andrew Morton
2003-12-17 21:41 ` Roger Luethi
2003-12-18 0:21 ` Rik van Riel
2003-12-18 22:53 ` Roger Luethi
2003-12-18 23:38 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200312090123.31895.kernel@kolivas.org \
--to=kernel@kolivas.org \
--cc=chris@cvine.freeserve.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@aracnet.com \
--cc=riel@redhat.com \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).