From: Harald Welte <laforge@netfilter.org>
To: "David S. Miller" <davem@redhat.com>
Cc: Stephen Lee <mukansai@emailplus.org>,
scott.feldman@intel.com, netfilter-devel@lists.netfilter.org,
linux-kernel@vger.kernel.org
Subject: Re: Extremely slow network with e1000 & ip_conntrack
Date: Thu, 11 Dec 2003 08:26:08 +0100 [thread overview]
Message-ID: <20031211072608.GF22826@sunbeam.de.gnumonks.org> (raw)
In-Reply-To: <20031205122819.25ac14ab.davem@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1284 bytes --]
On Fri, Dec 05, 2003 at 12:28:19PM -0800, David S. Miller wrote:
> The culprit is net/ipv4/netfilter/ip_conntrack_standalone.c,
> in ip_refrag(), it does this:
>
Sorry for getting back to you so late, but as indicated before, I was
offline while travelling during the last week.
Thanks for spotting and fixing the bug.
> Some auditing is definitely necessary wrt. TSO and netfilter. In particular
> I am incredibly confident that we have issues in cases like when the FTP
> netfilter modules mangle the data. Another area for inspection are the
> cases where TCP header bits are changed and thus the checksum needs to
> be adjusted.
yes, this is certainly a problem - but not with conntrack, only with
nat. So maybe we should add a safeguard, preventing
iptables_nat/ipchains/ipfwadm from being loaded when TSO on any
interface is enabled? Or at least print a warining in syslog?
--
- Harald Welte <laforge@netfilter.org> http://www.netfilter.org/
============================================================================
"Fragmentation is like classful addressing -- an interesting early
architectural error that shows how much experimentation was going
on while IP was being designed." -- Paul Vixie
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2003-12-11 7:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-04 6:51 Extremely slow network with e1000 & ip_conntrack Feldman, Scott
2003-12-04 12:36 ` Stephen Lee
2003-12-04 18:24 ` David S. Miller
2003-12-05 20:45 ` Stephen Lee
2003-12-05 20:28 ` David S. Miller
2003-12-05 22:20 ` Stephen Lee
2003-12-05 22:56 ` David S. Miller
2003-12-11 7:26 ` Harald Welte [this message]
2003-12-11 8:25 ` Henrik Nordstrom
2003-12-11 11:03 ` TSO and netfilter (Re: Extremely slow network with e1000 & ip_conntrack) Harald Welte
2003-12-12 1:41 ` David S. Miller
2003-12-12 7:01 ` Harald Welte
2003-12-12 8:00 ` David S. Miller
-- strict thread matches above, loose matches on Subject: below --
2003-12-04 17:37 Extremely slow network with e1000 & ip_conntrack Feldman, Scott
2003-12-04 18:30 ` David S. Miller
2003-12-04 19:53 ` Stephen Lee
2003-12-04 20:09 ` Jeff Garzik
2003-12-05 13:25 ` Stephen Lee
2003-12-04 20:20 ` David S. Miller
2003-12-04 7:24 Feldman, Scott
[not found] <20031126174943.0AA5.MUKANSAI@emailplus.org>
[not found] ` <20031129042551.A460.MUKANSAI@emailplus.org>
[not found] ` <20031130074532.0105.MUKANSAI@emailplus.org>
2003-11-30 15:52 ` Harald Welte
2003-12-02 11:44 ` Stephen Lee
2003-12-03 5:03 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031211072608.GF22826@sunbeam.de.gnumonks.org \
--to=laforge@netfilter.org \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mukansai@emailplus.org \
--cc=netfilter-devel@lists.netfilter.org \
--cc=scott.feldman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).