From: viro@parcelfarce.linux.theplanet.co.uk
To: Anton Altaparmakov <aia21@cam.ac.uk>
Cc: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org,
linux-ntfs-dev@lists.sourceforge.net
Subject: Re: [PATCH 6/10] Re: [2.6-BK-URL] NTFS: 2.1.19 sparse annotation, cleanups and a bugfix
Date: Sat, 25 Sep 2004 07:35:19 +0100 [thread overview]
Message-ID: <20040925063519.GQ23987@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <Pine.LNX.4.60.0409241713380.19983@hermes-1.csi.cam.ac.uk>
On Fri, Sep 24, 2004 at 05:13:53PM +0100, Anton Altaparmakov wrote:
> /* Get the starting vcn of the index_block holding the child node. */
> - vcn = sle64_to_cpup((u8*)ie + le16_to_cpu(ie->length) - 8);
> + vcn = sle64_to_cpup((sle64*)((u8*)ie + le16_to_cpu(ie->length) - 8));
I don't like the look of that. Are there any alignment warranties for that
pointer? The same goes for other users of that function...
next prev parent reply other threads:[~2004-09-25 6:35 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-24 16:11 [2.6-BK-URL] NTFS: 2.1.19 sparse annotation, cleanups and a bugfix Anton Altaparmakov
2004-09-24 16:12 ` [PATCH 1/10] " Anton Altaparmakov
2004-09-24 16:12 ` [PATCH 2/10] " Anton Altaparmakov
2004-09-24 16:13 ` [PATCH 3/10] " Anton Altaparmakov
2004-09-24 16:13 ` [PATCH 4/10] " Anton Altaparmakov
2004-09-24 16:13 ` [PATCH 5/10] " Anton Altaparmakov
2004-09-24 16:13 ` [PATCH 6/10] " Anton Altaparmakov
2004-09-24 16:14 ` [PATCH 7/10] " Anton Altaparmakov
2004-09-24 16:14 ` [PATCH 8/10] " Anton Altaparmakov
2004-09-24 16:15 ` [PATCH 9/10] " Anton Altaparmakov
2004-09-24 16:15 ` [PATCH 10/10] " Anton Altaparmakov
2004-09-24 16:30 ` [PATCH 8/10] " Linus Torvalds
2004-09-24 20:02 ` Anton Altaparmakov
2004-09-25 2:46 ` Linus Torvalds
2004-09-25 7:25 ` viro
2004-09-25 15:43 ` Linus Torvalds
2004-09-26 7:48 ` Anton Altaparmakov
2004-09-26 16:39 ` Linus Torvalds
2004-09-26 7:47 ` Anton Altaparmakov
2004-09-26 7:51 ` Anton Altaparmakov
2004-09-25 6:38 ` [PATCH 7/10] " viro
2004-09-25 23:31 ` Anton Altaparmakov
2004-09-25 6:35 ` viro [this message]
2004-09-25 23:09 ` [PATCH 6/10] " Anton Altaparmakov
2004-09-26 0:10 ` Anton Altaparmakov
2004-09-25 6:32 ` [PATCH 4/10] " viro
2004-09-26 0:06 ` Anton Altaparmakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040925063519.GQ23987@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=aia21@cam.ac.uk \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntfs-dev@lists.sourceforge.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).