From: Pavel Machek <pavel@ucw.cz>
To: linux@horizon.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: Suspend 2 merge
Date: Sat, 27 Nov 2004 23:25:35 +0100 [thread overview]
Message-ID: <20041127222535.GA1445@elf.ucw.cz> (raw)
In-Reply-To: <20041127220752.16491.qmail@science.horizon.com>
Hi!
> > My machine suspends in 7 seconds, and that's swsusp1. According to
> > your numbers, suspend2 should suspend it in 1 second and LZE
> > compressed should be .5 second.
> >
> > I'd say "who cares". 7 seconds seems like fast enough for me. And I'm
> > *not* going to add 2000 lines of code for 500msec speedup during
> > suspend.
>
> Lucky you. My machine takes minutes.
> (To be precise, it prints about a line and a half of dots in the
> count_data_pages() loop, and often takes 2 seconds per dot.)
>
> AMD Athlon XP, 1066 MHz, 768K RAM, VIA KT133 chipset.
> Stock 2.6.10-rc1.
>
> I could really use a speedup.
Yep, that's O(n^2) algorithm slowing it down. I have fix for it, but
2.6.10 is now too frozen for performance fix to go in. See "bigdiff" I
sent to hugang, or wait few minutes and you'll get really ugly diff in
private email, that should solve it, too.
[I'll be glad when you report results. It should make count_data_pages
< 1 second].
> if nothing else. But complaining that it doesn't annoy *you* isn't the
> most valid argument.
Ok, it is the scale. Half a second speedup is not enough to justify
new compression algorithm in the kernel.
Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
next prev parent reply other threads:[~2004-11-27 22:26 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-27 22:07 Suspend 2 merge linux
2004-11-27 22:25 ` Pavel Machek [this message]
2004-11-28 8:29 ` Wichert Akkerman
2004-11-28 11:37 ` Pavel Machek
2004-11-28 16:23 ` software suspend patch [1/6] hugang
2004-11-28 16:24 ` software suspend patch [2/6] hugang
2004-11-28 17:03 ` Pavel Machek
2004-11-28 16:24 ` software suspend patch [3/6] hugang
2004-11-28 16:25 ` software suspend patch [4/6] hugang
2004-11-28 17:08 ` Pavel Machek
2004-11-28 16:25 ` software suspend patch [5/6] hugang
2004-11-28 16:25 ` software suspend patch [1/6] hugang
2004-11-28 17:11 ` Pavel Machek
2004-12-02 20:56 ` Guido Guenther
2004-11-28 16:58 ` Pavel Machek
2004-11-29 15:43 ` hugang
2005-01-09 22:43 ` Pavel Machek
2005-01-11 2:01 ` hugang
2005-01-11 3:15 ` Pavel Machek
-- strict thread matches above, loose matches on Subject: below --
2004-11-24 12:56 Suspend 2 merge Nigel Cunningham
2004-11-24 13:28 ` Christoph Hellwig
2004-11-24 20:46 ` Nigel Cunningham
2004-11-25 19:20 ` Pavel Machek
2004-11-25 22:34 ` Nigel Cunningham
2004-11-25 23:22 ` Pavel Machek
2004-11-25 23:46 ` Nigel Cunningham
2004-11-26 0:39 ` Pavel Machek
2004-11-26 9:08 ` Nigel Cunningham
2004-11-26 12:38 ` Pavel Machek
2004-11-26 15:54 ` Christoph Hellwig
2004-11-26 22:36 ` Pavel Machek
2004-11-28 22:35 ` Nigel Cunningham
2004-11-28 23:55 ` Pavel Machek
2004-11-29 3:20 ` Nigel Cunningham
2004-11-29 13:03 ` Pavel Machek
2004-11-30 0:24 ` Nigel Cunningham
2004-11-30 10:19 ` Pavel Machek
[not found] ` <20041126082109.GA842@hugang.soulinfo.com>
2004-11-26 13:25 ` Pavel Machek
[not found] ` <20041126043203.GA2713@hugang.soulinfo.com>
2004-11-26 9:08 ` Nigel Cunningham
2004-11-26 13:37 ` Pavel Machek
2004-11-26 13:31 ` Pavel Machek
2004-11-28 21:40 ` Nigel Cunningham
2004-11-29 9:34 ` Stefan Seyfried
2004-11-29 22:20 ` Nigel Cunningham
2004-11-29 22:34 ` Pavel Machek
2004-11-30 12:16 ` Stefan Seyfried
2004-11-30 21:16 ` Nigel Cunningham
2004-11-30 22:20 ` Pavel Machek
2004-12-01 9:27 ` Nigel Cunningham
2004-12-01 10:08 ` Pavel Machek
2004-12-01 20:39 ` Nigel Cunningham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041127222535.GA1445@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@horizon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).