From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262645AbULPIbM (ORCPT ); Thu, 16 Dec 2004 03:31:12 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262644AbULPIbL (ORCPT ); Thu, 16 Dec 2004 03:31:11 -0500 Received: from mail.mellanox.co.il ([194.90.237.34]:37708 "EHLO mtlex01.yok.mtl.com") by vger.kernel.org with ESMTP id S262645AbULPIa5 (ORCPT ); Thu, 16 Dec 2004 03:30:57 -0500 Date: Thu, 16 Dec 2004 10:30:58 +0200 From: "Michael S. Tsirkin" To: Andrew Morton Cc: Andi Kleen , mingo@elte.hu, rlrevell@joe-job.com, tiwai@suse.de, linux-kernel@vger.kernel.org, pavel@suse.cz, discuss@x86-64.org, gordon.jin@intel.com, alsa-devel@lists.sourceforge.net, greg@kroah.com Subject: Re: [discuss] Re: unregister_ioctl32_conversion and modules. ioctl32 revisited. Message-ID: <20041216083058.GA21887@mellanox.co.il> Reply-To: "Michael S. Tsirkin" References: <20041215065650.GM27225@wotan.suse.de> <20041215074635.GC11501@mellanox.co.il> <1103135460.18982.68.camel@krustophenia.net> <20041216050356.GH32718@wotan.suse.de> <20041216075301.GC11047@elte.hu> <20041216080952.GL32718@wotan.suse.de> <20041216002539.60d37dfe.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041216002539.60d37dfe.akpm@osdl.org> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hello! Quoting r. Andrew Morton (akpm@osdl.org) "Re: [discuss] Re: unregister_ioctl32_conversion and modules. ioctl32 revisited.": > Andi Kleen wrote: > > > > I think Michael's patch is best (but I'm probably biased) because it addresses > > the independent problem of a race in unregister_ioctl32_conversion() too > > (and some other smaller issues in ioctl 32bit emulation) > > They should be separate patches. > > > Andrew, could we replace unlocked_ioctl.patch with Michael's patch? > > Where would one locate Michael's patch? Here it is for review (against 2.6.10-rc3) http://lkml.org/lkml/2004/12/15/62 I plan to incorporate Arnd Bergmann's comments and repost later today. MST