From: Tom Rini <trini@kernel.crashing.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 2.6.10-mm2] Use the new preemption code [3/3]
Date: Mon, 10 Jan 2005 07:56:15 -0700 [thread overview]
Message-ID: <20050110145615.GC2226@smtp.west.cox.net> (raw)
In-Reply-To: <1105318804.17853.5.camel@tglx.tec.linutronix.de>
On Mon, Jan 10, 2005 at 02:00:04AM +0100, Thomas Gleixner wrote:
> This patch adjusts the PPC entry code to use the fixed up
> preempt_schedule() handling in 2.6.10-mm2
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
>
> ---
> entry.S | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
> ---
> Index: 2.6.10-mm1/arch/ppc/kernel/entry.S
> ===================================================================
> --- 2.6.10-mm1/arch/ppc/kernel/entry.S (revision 141)
> +++ 2.6.10-mm1/arch/ppc/kernel/entry.S (working copy)
> @@ -624,12 +624,12 @@
> beq+ restore
> andi. r0,r3,MSR_EE /* interrupts off? */
> beq restore /* don't schedule if so */
> -1: lis r0,PREEMPT_ACTIVE@h
> +1: li r0,1
Perhaps I just don't have enough context, but is there good reason to
use a magic constant instead of a define ?
--
Tom Rini
http://gate.crashing.org/~trini/
next prev parent reply other threads:[~2005-01-10 14:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-10 0:35 [PATCH 2.6.10-mm2] Fix preemption race [1/3] (Core) tglx
2005-01-10 0:53 ` [PATCH 2.6.10-mm2] Use the new preemption code [2/3] Thomas Gleixner
2005-01-10 1:06 ` Russell King
2005-01-10 1:18 ` [PATCH 2.6.10-mm2] Use the new preemption code [2/3] Resend Thomas Gleixner
2005-01-10 7:32 ` Andrew Morton
2005-01-10 10:57 ` Thomas Gleixner
2005-01-10 9:46 ` Russell King
2005-01-10 10:12 ` Thomas Gleixner
2005-01-10 11:02 ` Ingo Molnar
2005-01-10 13:46 ` Thomas Gleixner
2005-01-10 1:00 ` [PATCH 2.6.10-mm2] Use the new preemption code [3/3] Thomas Gleixner
2005-01-10 14:56 ` Tom Rini [this message]
2005-01-10 15:49 ` tglx
2005-01-10 9:15 ` [PATCH 2.6.10-mm2] Fix preemption race [1/3] (Core) Ingo Molnar
2005-01-10 10:14 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050110145615.GC2226@smtp.west.cox.net \
--to=trini@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).