From: Greg KH <greg@kroah.com>
To: Jon Smirl <jonsmirl@gmail.com>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Export symbol from I2C eeprom driver
Date: Wed, 12 Jan 2005 15:21:12 -0800 [thread overview]
Message-ID: <20050112232112.GD15085@kroah.com> (raw)
In-Reply-To: <9e4733910501101820388563bb@mail.gmail.com>
On Mon, Jan 10, 2005 at 09:20:49PM -0500, Jon Smirl wrote:
> On Mon, 10 Jan 2005 15:47:26 -0800, Greg KH <greg@kroah.com> wrote:
> > > I don't want to load the driver from the script because the radeon
> > > driver is creating a sysfs link into the eeprom directory from the
> > > radeon one.
> >
> > How are you getting the kobject to the eeprom directory from the radeon
> > driver?
> >
>
> I own the private I2C bus and eeprom is the only chip that will attach
> to the bus. I need to do the link in the driver since there are four
> busses and upto two monitors. The driver knows how to pair the head up
> with the right bus.
>
> if (dev_priv->primary_head.connector != ddc_none)
> list_for_each(item,
> &dev_priv->i2c[dev_priv->primary_head.connector].adapter.clients) {
> client = list_entry(item, struct i2c_client, list);
> sysfs_create_link(&dev->primary.dev_class->kobj,
> &client->dev.kobj, "monitor");
> break;
> }
Ick. Oh well, sure, that's ok. But I really think that a Kconfig rule
could be made for this, instead of trying to pull an exported symbol in.
And I have a patch in my queue to delete that id, so you will have to
come up with another symbol in the driver to do that with :)
thanks,
greg k-h
prev parent reply other threads:[~2005-01-12 23:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-08 5:34 [PATCH] Export symbol from I2C eeprom driver Jon Smirl
2005-01-08 5:53 ` Greg KH
2005-01-08 6:08 ` Jon Smirl
2005-01-08 22:27 ` Greg KH
2005-01-09 0:14 ` Jon Smirl
2005-01-10 23:47 ` Greg KH
2005-01-11 2:20 ` Jon Smirl
2005-01-12 23:21 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050112232112.GD15085@kroah.com \
--to=greg@kroah.com \
--cc=jonsmirl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).