From: long <tlnguyen@snoqualmie.dp.intel.com>
To: greg@kroah.com
Cc: linux-kernel@vger.kernel.org, tom.l.nguyen@intel.com
Subject: Re:[PATCH] PCI: add PCI Express Port Bus Driver subsystem
Date: Mon, 24 Jan 2005 12:10:25 -0800 [thread overview]
Message-ID: <200501242010.j0OKAPIr003363@snoqualmie.dp.intel.com> (raw)
On Tuesday, January 18, 2005 5:03 PM Greg KH wrote:
>> >
>> >That would be great, but it doesn't show up that way on my box. All
>> >of
>> >the portX devices are in /sys/devices/ which is what I don't think
>> >you
>> >want. I would love for them to have the parent of the pci_dev
>> >structure
>> >:)
>>
>> Agree. Thanks for your inputs. The patch below include the changes
>> based on your previous post.
>
>Hm, that seems like a pretty big patch just to add a pointer to a parent
>device :)
>
>What really does this patch do? What does the sysfs tree now look like?
Before changes:
The patch makes the parent of the device pointing to the pci_dev
structure. The parents portX devices are in /sys/devices which
should be removed based on your suggestions. Below is /sys/devices
before any changes made.
/sys/devices
|
__ ide0
|
__ pci0000:00
|
__ pnp0
|
__ port1
| |
| __ port1.00
| |
| __ port1.01
| .
| .
| .
|
__ port2
|
__ port3
|
__ system
After changes:
The parents portX devices are no longer necessary because port1.00
and port1.01 devices shoud have the parent of the pci_dev structure
(based on your suggestion). The patch does the following changes:
- remove code creating and handling the parent portX devices.
- rename portX.YZ to pcieYZ (for example port1.00 renamed to pcie00)
since portX is no longer needed.
- make pcieYZ have the parent of the pci_dev structure.
Below is /sys/devices after changes made to the patch.
/sys/devices
|
__ ide0
|
__ pci0000:00
| |
| __ 0000:00:00.0
| |
| __ 0000:00:04.0
| | |
| . __ class
| . |
| . __ pcie00
| |
| __ pcie01
| .
| .
| .
|
__ platform
|
__ pnp0
|
__ system
Please let me know what you think of the changes.
Thanks,
Long
next reply other threads:[~2005-01-24 19:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-24 20:10 long [this message]
2005-02-01 7:39 ` [PATCH] PCI: add PCI Express Port Bus Driver subsystem Greg KH
-- strict thread matches above, loose matches on Subject: below --
2005-01-19 1:59 long
2005-01-18 19:28 long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200501242010.j0OKAPIr003363@snoqualmie.dp.intel.com \
--to=tlnguyen@snoqualmie.dp.intel.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tom.l.nguyen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).