From: Andrew Morton <akpm@osdl.org>
To: Arjan van de Ven <arjan@infradead.org>
Cc: ak@suse.de, linux-kernel@vger.kernel.org, sct@redhat.com, mingo@elte.hu
Subject: Re: 2.6.15-git7 oopses in ext3 during LTP runs
Date: Wed, 11 Jan 2006 13:07:28 -0800 [thread overview]
Message-ID: <20060111130728.579ab429.akpm@osdl.org> (raw)
In-Reply-To: <1137012917.2929.78.camel@laptopd505.fenrus.org>
Arjan van de Ven <arjan@infradead.org> wrote:
>
> On Wed, 2006-01-11 at 12:46 -0800, Andrew Morton wrote:
> > Andi Kleen <ak@suse.de> wrote:
> > >
> > >
> > > Running LTP with the default runfile on a 4 virtual CPU x86-64
> > > system gives
> > >
> > > To reproduce: run ltp 20040908 (newer one will probably work
> > > too) with runltp -p -q -l `uname -r` on a ext3 file system
> > >
> > > config is x86-64 defconfig.
> > >
> >
> > mutex_trylock() is returning the wrong value. fs/super.c:write_super()
> > clearly took the lock.
>
>
> the conversion is buggy.
>
> mutex_trylock has the same convention as spin_try_lock (which is the
> opposite of down_trylock). THe conversion forgot to add a !
>
> --- linux-2.6.15/fs/ext3/super.c~ 2006-01-11 21:54:13.000000000 +0100
> +++ linux-2.6.15/fs/ext3/super.c 2006-01-11 21:54:13.000000000 +0100
> @@ -2150,7 +2150,7 @@
>
> static void ext3_write_super (struct super_block * sb)
> {
> - if (mutex_trylock(&sb->s_lock) != 0)
> + if (!mutex_trylock(&sb->s_lock) != 0)
> BUG();
> sb->s_dirt = 0;
> }
We expect the lock to be held on entry. Hence we expect mutex_trylock()
to return zero.
next prev parent reply other threads:[~2006-01-11 21:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-11 20:26 2.6.15-git7 oopses in ext3 during LTP runs Andi Kleen
2006-01-11 20:46 ` Andrew Morton
2006-01-11 20:55 ` Arjan van de Ven
2006-01-11 21:07 ` Andrew Morton [this message]
2006-01-11 21:27 ` Arjan van de Ven
2006-01-11 22:19 ` Ingo Molnar
2006-01-11 22:40 ` Pavel Machek
2006-01-11 22:44 ` David S. Miller
2006-01-12 0:30 ` Ingo Molnar
2006-01-11 22:47 ` Jesper Juhl
2006-01-12 8:51 ` Pavel Machek
2006-01-12 0:55 ` 2.6.15-git7 oopses in ext3 during LTP runs II - more problems Andi Kleen
2006-01-12 1:14 ` Andrew Morton
2006-01-12 1:25 ` Andi Kleen
2006-01-11 21:25 ` 2.6.15-git7 oopses in ext3 during LTP runs Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060111130728.579ab429.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=ak@suse.de \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sct@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).