From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751501AbWAKOuh (ORCPT ); Wed, 11 Jan 2006 09:50:37 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751511AbWAKOuh (ORCPT ); Wed, 11 Jan 2006 09:50:37 -0500 Received: from ns.virtualhost.dk ([195.184.98.160]:52330 "EHLO virtualhost.dk") by vger.kernel.org with ESMTP id S1751501AbWAKOug (ORCPT ); Wed, 11 Jan 2006 09:50:36 -0500 Date: Wed, 11 Jan 2006 15:52:03 +0100 From: Jens Axboe To: Reuben Farrelly Cc: Andrew Morton , neilb@suse.de, mingo@elte.hu, linux-kernel@vger.kernel.org, Jeff Garzik , htejun@gmail.com Subject: Re: 2.6.15-mm2 Message-ID: <20060111145201.GS3389@suse.de> References: <17348.34472.105452.831193@cse.unsw.edu.au> <43C4947C.1040703@reub.net> <20060110213001.265a6153.akpm@osdl.org> <20060110213056.58f5e806.akpm@osdl.org> <43C4E2BE.6050800@reub.net> <20060111030529.0bc03e0a.akpm@osdl.org> <20060111111313.GD3389@suse.de> <43C4EEA4.3050502@reub.net> <20060111115616.GE3389@suse.de> <43C518BC.5090903@reub.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <43C518BC.5090903@reub.net> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 12 2006, Reuben Farrelly wrote: > > > On 12/01/2006 12:56 a.m., Jens Axboe wrote: > >On Thu, Jan 12 2006, Reuben Farrelly wrote: > >> > >>On 12/01/2006 12:13 a.m., Jens Axboe wrote: > >>>On Wed, Jan 11 2006, Andrew Morton wrote: > >>>>Neil thinks that an IO got lost. In the git2->git3 diff we have: > >>>> > >>>>b/drivers/scsi/Kconfig | 10 > >>>>b/drivers/scsi/ahci.c | 1 > >>>>b/drivers/scsi/ata_piix.c | 5 > >>>>b/drivers/scsi/libata-core.c | 145 + > >>>>b/drivers/scsi/libata-scsi.c | 48 > >>>>b/drivers/scsi/libata.h | 4 > >>>>b/drivers/scsi/sata_mv.c | 1 > >>>>b/drivers/scsi/sata_promise.c | 1 > >>>>b/drivers/scsi/sata_sil.c | 1 > >>>>b/drivers/scsi/sata_sil24.c | 1 > >>>>b/drivers/scsi/sata_sx4.c | 1 > >>>>b/drivers/scsi/scsi_lib.c | 50 > >>>>b/drivers/scsi/scsi_sysfs.c | 31 > >>>>b/drivers/scsi/sd.c | 85 - > >>>>b/fs/bio.c | 26 > >>>> > >>>>Jens, Jeff: were any of those changes added in the final day or two, not > >>>>included in the trees which I pull? > >>>Reuben, do you have any barrier= options in your fstab for any reiser > >>>file system? > >>None whatsoever: > >> > >>/dev/md0 / reiserfs defaults > >>0 0 > >>none /dev/pts devpts gid=5,mode=620 > >>0 0 > >>none /dev/shm tmpfs defaults > >>0 0 > >>none /proc proc defaults > >>0 0 > >>sysfs /sys sysfs defaults > >>0 0 > >>/dev/sda1 /boot ext3 defaults > >>1 2 > >>#/dev/sdb1 /boot-2 ext3 defaults > >>1 2 > >>/dev/md1 /home reiserfs defaults > >>0 0 > >>/dev/md2 /var reiserfs defaults > >>0 0 > >>/dev/md3 /var/www/cgi-bin reiserfs defaults > >>0 0 > >>/dev/md4 /tmp reiserfs defaults > >>0 0 > >>/dev/md5 /backup reiserfs defaults > >>0 0 > >>/dev/sda8 /var/spool/squid-1 reiserfs noatime,notail > >>0 0 > >>/dev/sdb8 /var/spool/squid-2 reiserfs noatime,notail > >>0 0 > >>/dev/sda9 swap swap defaults > >>0 0 > >>/dev/sdb9 swap swap defaults > >>0 0 > >>/dev/sdc1 /store reiserfs defaults > >>0 0 > >>/dev/shm /var/spool/amavisd/tmp tmpfs > >>defaults,size=25m,mode=700,uid=508,gid=509, 0 0 > >>/dev/fd0 /media/floppy auto > >>pamconsole,exec,noauto,managed 0 0 > > > >Then the barrier changes from git2 -> git3 should not have anything to > >do with it. Strange... I guess you should try the git bisect method to > >narrow it down. > > Ok push came to shove, so I spent the evening (early hours of the morning > really) learning how to git my way around a little and use git bisect. Not > bad, people who come up with clever stuff like that would probably be > clever enough to be able to do kernel development or something ;-) > > Anyway, humour aside, I've bisected down to six revisions: > > [root@tornado linux-2.6]# git bisect good > Bisecting: 6 revisions left to test after this > [93c9338713d4e11102cd09b4670ad42a336b06a3] [BLOCK] update libata to use new > blk_ordered for barriers > [root@tornado linux-2.6]# > > however I'm not sure I can go a lot further now as the tree is failing to > compile at that point: > > include/asm/mpspec_def.h:78: warning: 'packed' attribute ignored for field > of type 'unsigned char[5u]' > block/ll_rw_blk.c:2421: error: conflicting types for 'blk_execute_rq_nowait' > include/linux/blkdev.h:617: error: previous declaration of > 'blk_execute_rq_nowait' was here > make[1]: *** [block/ll_rw_blk.o] Error 1 > make: *** [block] Error 2 > [root@tornado linux-2.6]# > > I'm guessing there are a block of changes that all go together around this > point. It's not too tricky, you just need to correct that function prototype. Could you do that? Would be nice to know _exactly_ which libata changeset caused this malfunction. But it does of course point at the barrier changes for scsi/libata... -- Jens Axboe