From: Stephen Hemminger <shemminger@osdl.org>
To: "Sean Hefty" <sean.hefty@intel.com>
Cc: "Hefty, Sean" <sean.hefty@intel.com>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<openib-general@openib.org>
Subject: Re: [PATCH 2/5] [RFC] Infiniband: connection abstraction
Date: Tue, 17 Jan 2006 15:38:38 -0800 [thread overview]
Message-ID: <20060117153838.3dc2cd2e@dxpl.pdx.osdl.net> (raw)
In-Reply-To: <ORSMSX401FRaqbC8wSA00000040@orsmsx401.amr.corp.intel.com>
Minor nits.
On Tue, 17 Jan 2006 15:24:37 -0800
"Sean Hefty" <sean.hefty@intel.com> wrote:
> The following patch extends matching connection requests to listens in the
> Infiniband CM to include private data.
>
> Signed-off-by: Sean Hefty <sean.hefty@intel.com>
>
> ---
> +static void cm_mask_compare_data(u8 *dst, u8 *src, u8 *mask)
static void cm_mask_compare_data(u8 *dst, const u8 *src, u8 *mask)
but I would rename it to cm_mask_copy since it doesn't really do a compare.
> +{
> + int i;
> +
> + for (i = 0; i < IB_CM_PRIVATE_DATA_COMPARE_SIZE; i++)
> + dst[i] = src[i] & mask[i];
> +}
> +
> +static int cm_compare_data(struct ib_cm_private_data_compare *src_data,
> + struct ib_cm_private_data_compare *dst_data)
static int cm_compare_data(const struct ib_cm_private_data_compare *src,
cosnt struct ib_cm_private_data_compare *dst)
Your data type names are getting too long ^^^^^^^^^^^^^^^^^^^^^^^^
<flamebait>
Also should infiniband exports be EXPORT_SYMBOL_GPL, to make
it clear that binary drivers for this are not allowed??
</flamebait>
--
Stephen Hemminger <shemminger@osdl.org>
OSDL http://developer.osdl.org/~shemminger
next prev parent reply other threads:[~2006-01-17 23:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-17 23:16 [PATCH 0/5] [RFC] Infiniband: connection abstraction Sean Hefty
2006-01-17 23:21 ` [PATCH 1/5] " Sean Hefty
2006-01-17 23:24 ` [PATCH 2/5] " Sean Hefty
2006-01-17 23:38 ` Stephen Hemminger [this message]
2006-01-17 23:51 ` Sean Hefty
2006-01-18 7:08 ` Arjan van de Ven
2006-01-18 20:27 ` Bryan O'Sullivan
2006-01-18 2:03 ` [openib-general] " Grant Grundler
2006-01-18 17:46 ` Sean Hefty
2006-01-18 18:02 ` Grant Grundler
2006-01-18 18:13 ` Sean Hefty
2006-01-17 23:28 ` [PATCH 3/5] " Sean Hefty
2006-01-21 23:37 ` [openib-general] " Roland Dreier
2006-01-17 23:37 ` [PATCH 4/5] " Sean Hefty
2006-01-17 23:44 ` [PATCH 5/5] " Sean Hefty
2006-01-18 15:43 ` [openib-general] " Roland Dreier
2006-01-18 15:44 ` Roland Dreier
2006-01-18 18:19 ` Sean Hefty
2006-01-18 18:49 ` Grant Grundler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060117153838.3dc2cd2e@dxpl.pdx.osdl.net \
--to=shemminger@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=openib-general@openib.org \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).