From: Andrew Morton <akpm@osdl.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: rostedt@goodmis.org, linux-kernel@vger.kernel.org, viro@ftp.linux.org.uk
Subject: Re: [patch, validator] fix proc_subdir_lock related deadlock
Date: Wed, 25 Jan 2006 10:23:51 -0800 [thread overview]
Message-ID: <20060125102351.28cd52b8.akpm@osdl.org> (raw)
In-Reply-To: <20060125180811.GA12762@elte.hu>
Ingo Molnar <mingo@elte.hu> wrote:
>
>
> * Steven Rostedt <rostedt@goodmis.org> wrote:
>
> > > proc_subdir_lock can also be used from softirq (tasklet) context, which
> > > may lead to deadlocks.
> > >
> > > This bug was found via the lock validator:
> > >
> >
> > Thanks Ingo,
> >
> > I stressed in sending the patch that there was a big assumption that
> > the calls would not be done in (soft)irq context. I just didn't want
> > to add overhead if it wasn't needed. But I guess that this is needed
> > until we can remove all the instances that use it in softirq context.
> > But that's for a later patch.
>
> the validator just found another problem with this lock, pointing out
> that files_lock nests inside of proc_subdir_lock, and that files_lock is
> a softirq-unsafe lock, creating another (unlikely but possible) deadlock
> scenario:
files_lock can be taken on the free_irq() path: proc_kill_inodes().
> ...
> to solve this we must either change files_lock to be softirq-safe too
> (bleh!), or we must forbid remove_proc_entry() use from softirq
> contexts. Neither is a happy solution - remove_proc_entry() is used
> within free_irq(), and who knows how many drivers do free_irq() in
> softirq/tasklet context ...
free_irq()'s /proc fiddling has always been a pain - we just shouldn't be
doing filesystem things in irq/bh context.
> Andrew, this needs to be resolved before v2.6.16, correct? Steve's patch
> solves a real bug in the upstream kernel.
It's not a very big bug - I think only Steve hit it, and that with a
stress-test which was somewhat tuned to hit it.
So we can afford to sit on the problem for a while, as long as someone is
working on a broader /proc-sanity fix. But nobody will do that.
I wonder if we can just punt the unregister_handler_proc/kfree up to a
keventd callback.
next prev parent reply other threads:[~2006-01-25 18:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-25 17:03 [patch, validator] fix proc_subdir_lock related deadlock Ingo Molnar
2006-01-25 17:14 ` Steven Rostedt
2006-01-25 18:08 ` Ingo Molnar
2006-01-25 18:14 ` [patch, validator] fix files_lock " Ingo Molnar
2006-01-25 18:23 ` Andrew Morton [this message]
2006-01-25 20:21 ` [patch, validator] fix proc_subdir_lock " Ingo Molnar
2006-01-26 0:02 ` [patch, lock validator] fix proc_inum_lock " Ingo Molnar
2006-01-26 0:11 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060125102351.28cd52b8.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).