linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Brad Boyer <flar@allandria.com>
To: Finn Thain <fthain@telegraphics.com.au>
Cc: Roman Zippel <zippel@linux-m68k.org>,
	Al Viro <viro@ftp.linux.org.uk>, Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org,
	Linux/m68k <linux-m68k@vger.kernel.org>
Subject: Re: [PATCH 08/21] gcc 4 fix
Date: Mon, 26 Jun 2006 10:43:19 -0700	[thread overview]
Message-ID: <20060626174319.GA20753@cynthia.pants.nu> (raw)
In-Reply-To: <Pine.LNX.4.64.0606241420330.1073@loopy.telegraphics.com.au>

On Sat, Jun 24, 2006 at 02:45:06PM +1000, Finn Thain wrote:
> On Fri, 23 Jun 2006, Roman Zippel wrote:
> > On Fri, 23 Jun 2006, Al Viro wrote:
> > > Broken.  Proper fix is to rename the function so that it wouldn't 
> > > clash.
> > 
> > Well, I wouldn't call it broken, as both versions can never be compiled 
> > into the same kernel, but I don't care much how it's fixed.
> > 
> > Does anyone know the relationship between via-pmu.c and via-pmu68k.c? If 
> > it's intended to keep the differences small, a rename would be the wrong 
> > fix.
> 
> The relationship is (and was) just that they share the pmu.h header file 
> declarations. In the patch in question I used the powerpc definition as 
> well.

I believe that pmu68k started out as a copy of pmu. The versions of PMU
on the 68k PowerBooks are just older than the ones on ppc. They are
fundamentally the same, it's just that the ppc systems have various fixes
and new features. Ideally the files would be merged back together and
split in a more logical fashion to share the code that is the same. Each
one already supports multiple versions of the chip.

> The powerpc version exports pmu_queue_request (apparently for the use of 
> low_i2c.c). The m68k version doesn't, but if it needed to export it, I 
> don't see why it shouldn't implement the same "API"?

Several other parts of the kernel submit pmu requests, but most of them
use pmu_request(). It's probably better to unify this API set. The cuda
and IIsi drivers have equivalent calls, for that matter. I wanted to
make a generic call that would switch to the active one of those, but
the idea didn't go over too well. It was probably due to the bad taste
everyone had from when adb_request() was used for that purpose.

	Brad Boyer
	flar@allandria.com


  reply	other threads:[~2006-06-27  1:34 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-23 18:30 [PATCH 00/21] m68k patches zippel
2006-06-23 18:30 ` [PATCH 01/21] fix uaccess.h for gcc-3.x zippel
2006-06-23 18:30 ` [PATCH 02/21] fix constraints of the signal functions and some cleanup zippel
2006-06-23 18:30 ` [PATCH 03/21] fix __iounmap for 030 zippel
2006-06-23 18:31 ` [PATCH 04/21] small flush_icache() cleanup zippel
2006-06-23 18:31 ` [PATCH 05/21] Add the generic dma API functions zippel
2006-06-23 18:31 ` [PATCH 06/21] dma API addition zippel
2006-06-23 18:31 ` [PATCH 07/21] fix show_registers() zippel
2006-06-23 18:31 ` [PATCH 08/21] gcc 4 fix zippel
2006-06-23 19:35   ` Al Viro
2006-06-23 20:05     ` Roman Zippel
2006-06-24  4:45       ` Finn Thain
2006-06-26 17:43         ` Brad Boyer [this message]
2006-06-23 18:31 ` [PATCH 09/21] separate handler for auto and user vector interrupt zippel
2006-06-23 18:31 ` [PATCH 10/21] cleanup generic irq names zippel
2006-06-23 18:31 ` [PATCH 11/21] cleanup amiga irq numbering zippel
2006-06-23 18:31 ` [PATCH 12/21] introduce irq controller zippel
2006-06-23 18:31 ` [PATCH 13/21] convert generic irq code to " zippel
2006-06-23 18:31 ` [PATCH 14/21] convert amiga irq code zippel
2006-06-23 18:31 ` [PATCH 15/21] convert apollo " zippel
2006-06-23 18:31 ` [PATCH 16/21] convert atari " zippel
2006-06-23 18:31 ` [PATCH 17/21] convert hp300 " zippel
2006-06-23 18:31 ` [PATCH 18/21] convert mac " zippel
2006-06-23 18:31 ` [PATCH 19/21] convert q40 " zippel
2006-06-23 18:31 ` [PATCH 20/21] convert sun3 " zippel
2006-06-23 18:31 ` [PATCH 21/21] convert VME " zippel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060626174319.GA20753@cynthia.pants.nu \
    --to=flar@allandria.com \
    --cc=akpm@osdl.org \
    --cc=fthain@telegraphics.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=viro@ftp.linux.org.uk \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).