linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: J?rn Engel <joern@logfs.org>, Jeff Garzik <jeff@garzik.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	linux-mm@kvack.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	miklos@szeredi.hu, akpm@linux-foundation.org, neilb@suse.de,
	dgc@sgi.com, tomoki.sekiyama.qu@hitachi.com,
	nikita@clusterfs.com, trond.myklebust@fys.uio.no,
	yingchao.zhou@gmail.com, richard@rsk.demon.co.uk, david@lang.hm
Subject: [patch] add noatime/atime boot options, CONFIG_DEFAULT_NOATIME
Date: Sun, 5 Aug 2007 10:18:13 +0200	[thread overview]
Message-ID: <20070805081812.GA13572@elte.hu> (raw)
In-Reply-To: <20070804200038.GA31017@elte.hu>


here's an updated patch that implements a full spectrum of config, boot 
and sysctl parameters to make it easy for users and distros to make 
noatime the default. Tested on ext3, with and without atime.

for compatibility reasons the config option defaults to disabled, so 
this patch has no impact by default. If CONFIG_DEFAULT_NOATIME is 
enabled for a kernel then all filesystems will be noatime mounted. The 
boot and sysctl options are available unconditionally.

	Ingo

---------------------------->
Subject: [patch] add noatime/atime boot options, CONFIG_DEFAULT_NOATIME
From: Ingo Molnar <mingo@elte.hu>

add the "noatime" (and "atime") boot options to enable/disable atime
updates for all filesystems.

also add the CONFIG_DEFAULT_NOATIME kernel option (disabled by default
for compatibility reasons), which makes "noatime" the default for all
mounts without an extra kernel boot option.

also add the /proc/sys/kernel/mount_with_atime flag which can be changed
runtime to modify the behavior of subsequent new mounts.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 Documentation/kernel-parameters.txt |   12 +++++++
 fs/Kconfig                          |   21 +++++++++++++
 fs/namespace.c                      |   56 ++++++++++++++++++++++++++++++++++++
 include/linux/mount.h               |    2 +
 kernel/sysctl.c                     |    9 +++++
 5 files changed, 100 insertions(+)

Index: linux/Documentation/kernel-parameters.txt
===================================================================
--- linux.orig/Documentation/kernel-parameters.txt
+++ linux/Documentation/kernel-parameters.txt
@@ -303,6 +303,12 @@ and is between 256 and 4096 characters. 
 
 	atascsi=	[HW,SCSI] Atari SCSI
 
+	atime           [FS] default to enabled atime updates on all
+			filesystems.
+
+	atime=          [FS] default to enabled/disabled atime updates on all
+			filesystems.
+
 	atkbd.extra=	[HW] Enable extra LEDs and keys on IBM RapidAccess,
 			EzKey and similar keyboards
 
@@ -1100,6 +1106,12 @@ and is between 256 and 4096 characters. 
 	noasync		[HW,M68K] Disables async and sync negotiation for
 			all devices.
 
+	noatime         [FS] default to disabled atime updates on all
+			filesystems.
+
+	noatime=        [FS] default to disabled/enabled atime updates on all
+			filesystems.
+
 	nobats		[PPC] Do not use BATs for mapping kernel lowmem
 			on "Classic" PPC cores.
 
Index: linux/fs/Kconfig
===================================================================
--- linux.orig/fs/Kconfig
+++ linux/fs/Kconfig
@@ -2060,6 +2060,27 @@ config 9P_FS
 
 endmenu
 
+config DEFAULT_NOATIME
+	bool "Mount all filesystems with noatime by default"
+	help
+	  If you say Y here, all your filesystems will be mounted
+	  with the "noatime" mount option. This eliminates atime
+	  ('file last accessed' timestamp) updates (which otherwise
+	  is performed on every file access and generates a write
+	  IO to the inode) and thus speeds up IO.
+
+	  The mtime ('file last modified') and ctime ('file created')
+	  timestamp are unaffected by this change.
+
+	  Note: the overwhelming majority of applications make no
+	  use of atime. Known exceptions: the Mutt mail client can
+	  depend on it (for new mail notification) on multi-user
+	  machines and some HSM backup tools might also work better
+	  in the presence of atime.
+
+	  Use the "atime" kernel boot option to turn off this
+	  feature.
+
 if BLOCK
 menu "Partition Types"
 
Index: linux/fs/namespace.c
===================================================================
--- linux.orig/fs/namespace.c
+++ linux/fs/namespace.c
@@ -1362,6 +1362,60 @@ int copy_mount_options(const void __user
 }
 
 /*
+ * Allow users to disable (or enable) atime updates via a .config
+ * option or via the boot line, or via /proc/sys/fs/mount_with_atime:
+ */
+int mount_with_atime __read_mostly =
+#ifdef CONFIG_DEFAULT_NOATIME
+0
+#else
+1
+#endif
+;
+
+/*
+ * The "noatime=", "atime=", "noatime" and "atime" boot parameters:
+ */
+static int toggle_atime_updates(int val)
+{
+	mount_with_atime = val;
+
+	printk("Atime updates are: %s\n", val ? "on" : "off");
+
+	return 1;
+}
+
+static int __init set_atime_setup(char *str)
+{
+	int val;
+
+	get_option(&str, &val);
+	return toggle_atime_updates(val);
+}
+__setup("atime=", set_atime_setup);
+
+static int __init set_noatime_setup(char *str)
+{
+	int val;
+
+	get_option(&str, &val);
+	return toggle_atime_updates(!val);
+}
+__setup("noatime=", set_noatime_setup);
+
+static int __init set_atime(char *str)
+{
+	return toggle_atime_updates(1);
+}
+__setup("atime", set_atime);
+
+static int __init set_noatime(char *str)
+{
+	return toggle_atime_updates(0);
+}
+__setup("noatime", set_noatime);
+
+/*
  * Flags is a 32-bit value that allows up to 31 non-fs dependent flags to
  * be given to the mount() call (ie: read-only, no-dev, no-suid etc).
  *
@@ -1409,6 +1463,8 @@ long do_mount(char *dev_name, char *dir_
 		mnt_flags |= MNT_NODIRATIME;
 	if (flags & MS_RELATIME)
 		mnt_flags |= MNT_RELATIME;
+	if (!mount_with_atime && !(flags & (MNT_NOATIME | MNT_NODIRATIME)))
+		mnt_flags |= MNT_NOATIME;
 
 	flags &= ~(MS_NOSUID | MS_NOEXEC | MS_NODEV | MS_ACTIVE |
 		   MS_NOATIME | MS_NODIRATIME | MS_RELATIME);
Index: linux/include/linux/mount.h
===================================================================
--- linux.orig/include/linux/mount.h
+++ linux/include/linux/mount.h
@@ -103,5 +103,7 @@ extern void shrink_submounts(struct vfsm
 extern spinlock_t vfsmount_lock;
 extern dev_t name_to_dev_t(char *name);
 
+extern int mount_with_atime;
+
 #endif
 #endif /* _LINUX_MOUNT_H */
Index: linux/kernel/sysctl.c
===================================================================
--- linux.orig/kernel/sysctl.c
+++ linux/kernel/sysctl.c
@@ -30,6 +30,7 @@
 #include <linux/capability.h>
 #include <linux/smp_lock.h>
 #include <linux/fs.h>
+#include <linux/mount.h>
 #include <linux/init.h>
 #include <linux/kernel.h>
 #include <linux/kobject.h>
@@ -1206,6 +1207,14 @@ static ctl_table fs_table[] = {
 		.mode		= 0644,
 		.proc_handler	= &proc_dointvec,
 	},
+	{
+		.ctl_name	= CTL_UNNUMBERED,
+		.procname	= "mount_with_atime",
+		.data		= &mount_with_atime,
+		.maxlen		= sizeof(int),
+		.mode		= 0644,
+		.proc_handler	= &proc_dointvec,
+	},
 #if defined(CONFIG_BINFMT_MISC) || defined(CONFIG_BINFMT_MISC_MODULE)
 	{
 		.ctl_name	= CTL_UNNUMBERED,

  parent reply	other threads:[~2007-08-05  8:19 UTC|newest]

Thread overview: 188+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-03 12:37 [PATCH 00/23] per device dirty throttling -v8 Peter Zijlstra
2007-08-03 12:37 ` [PATCH 01/23] nfs: remove congestion_end() Peter Zijlstra
2007-08-03 12:37 ` [PATCH 02/23] lib: percpu_counter_add Peter Zijlstra
2007-08-03 12:37 ` [PATCH 03/23] lib: percpu_counter variable batch Peter Zijlstra
2007-08-03 12:37 ` [PATCH 04/23] lib: make percpu_counter_add take s64 Peter Zijlstra
2007-08-03 12:37 ` [PATCH 05/23] lib: percpu_counter_set Peter Zijlstra
2007-08-03 12:37 ` [PATCH 06/23] lib: percpu_counter_sum_positive Peter Zijlstra
2007-08-03 12:37 ` [PATCH 07/23] lib: percpu_count_sum() Peter Zijlstra
2007-08-03 12:37 ` [PATCH 08/23] lib: percpu_counter_init error handling Peter Zijlstra
2007-08-03 12:37 ` [PATCH 09/23] lib: percpu_counter_init_irq Peter Zijlstra
2007-08-03 12:37 ` [PATCH 10/23] mm: bdi init hooks Peter Zijlstra
2007-08-03 12:37 ` [PATCH 11/23] containers: " Peter Zijlstra
2007-08-03 12:37 ` [PATCH 12/23] mtd: " Peter Zijlstra
2007-08-03 12:37 ` [PATCH 13/23] mtd: clean up the backing_dev_info usage Peter Zijlstra
2007-08-03 12:37 ` [PATCH 14/23] mtd: give mtdconcat devices their own backing_dev_info Peter Zijlstra
2007-08-03 12:37 ` [PATCH 15/23] mm: scalable bdi statistics counters Peter Zijlstra
2007-08-03 12:37 ` [PATCH 16/23] mm: count reclaimable pages per BDI Peter Zijlstra
2007-08-03 12:37 ` [PATCH 17/23] mm: count writeback " Peter Zijlstra
2007-08-09 19:15   ` Christoph Lameter
2007-08-09 19:23     ` Peter Zijlstra
2007-08-09 19:27       ` Christoph Lameter
2007-08-13  8:36         ` Peter Zijlstra
2007-08-03 12:37 ` [PATCH 18/23] mm: expose BDI statistics in sysfs Peter Zijlstra
2007-08-03 12:37 ` [PATCH 19/23] lib: floating proportions Peter Zijlstra
2007-08-03 12:37 ` [PATCH 20/23] lib: floating proportions _single Peter Zijlstra
2007-08-03 12:37 ` [PATCH 21/23] mm: per device dirty threshold Peter Zijlstra
2007-08-03 12:37 ` [PATCH 22/23] mm: dirty balancing for tasks Peter Zijlstra
2007-08-03 12:37 ` [PATCH 23/23] debug: sysfs files for the current ratio/size/total Peter Zijlstra
2007-08-03 22:21 ` [PATCH 00/23] per device dirty throttling -v8 Linus Torvalds
2007-08-04  6:32   ` Ingo Molnar
2007-08-04  7:07     ` Ingo Molnar
2007-08-04  7:44       ` david
2007-08-04 16:01         ` Ray Lee
2007-08-04 17:15           ` david
2007-08-09  5:11           ` david
2007-08-04 10:33       ` Ingo Molnar
2007-08-04 16:17         ` Linus Torvalds
2007-08-04 16:37           ` Ingo Molnar
2007-08-04 16:51             ` Andrew Morton
2007-08-04 16:56               ` Ingo Molnar
2007-08-04 20:23                 ` Alan Cox
2007-08-04 17:02             ` Diego Calleja
2007-08-04 17:17               ` Ingo Molnar
2007-08-04 17:38                 ` Diego Calleja
2007-08-04 17:51                   ` Diego Calleja
2007-08-08 10:43                 ` Karel Zak
2007-08-04 17:39             ` Linus Torvalds
2007-08-04 18:08               ` Jeff Garzik
2007-08-04 19:12                 ` Jörn Engel
2007-08-04 19:21                   ` Ingo Molnar
2007-08-04 19:26                     ` Jörn Engel
2007-08-04 19:42                       ` Jörn Engel
2007-08-05 20:36                         ` Christoph Hellwig
2007-08-06 18:03                           ` Chuck Ebbert
2007-08-06 18:53                             ` Jeff Garzik
2007-08-06 19:37                             ` Alan Cox
2007-08-06 19:46                               ` Chuck Ebbert
2007-08-07  7:05                                 ` Ingo Molnar
2007-08-08 21:10                           ` Martin J. Bligh
2007-08-08 21:21                             ` Andrew Morton
2007-08-09  0:54                               ` Martin Bligh
2007-08-11 23:14                                 ` Valerie Henson
2007-08-10  0:21                               ` Bill Davidsen
2007-08-14  9:57                           ` Helge Hafting
2007-08-04 19:47                       ` Linus Torvalds
2007-08-04 19:49                         ` Linus Torvalds
2007-08-04 20:00                         ` Ingo Molnar
2007-08-04 20:11                           ` Ingo Molnar
2007-08-04 20:13                             ` Arjan van de Ven
2007-08-05  8:18                           ` Ingo Molnar [this message]
2007-08-04 20:13                         ` Arjan van de Ven
2007-08-04 21:48                           ` Theodore Tso
2007-08-05 18:01                             ` Arjan van de Ven
2007-08-05 20:34                               ` Christoph Hellwig
     [not found]                         ` <fa.7rstQpXif2z9y2n2HD+qxLFnueg@ifi.uio.no>
     [not found]                           ` <fa.6VOZrceT65Vh8CIRIta0zSg2V38@ifi.uio.no>
     [not found]                             ` <fa.xcZCTa5cHDOhrcyXZ2gZbzbu7g0@ifi.uio.no>
     [not found]                               ` <fa.JjZwG90x+07YaOx8h5VLN+9AL/8@ifi.uio.no>
     [not found]                                 ` <fa.V9U4mAEXVjNqblhzu7GRmxif7Uw@ifi.uio.no>
     [not found]                                   ` <fa.uq0BQtrgp66a08hpsF+vrqXUNC4@ifi.uio.no>
2007-08-15 18:16                                     ` david.balazic
2007-08-04 20:11                     ` [PATCH 00/23] " Alan Cox
2007-08-04 20:28                       ` Jeff Garzik
2007-08-04 21:47                         ` Alan Cox
2007-08-04 23:51                           ` Claudio Martins
2007-08-05  0:49                             ` Alan Cox
2007-08-05  7:28                               ` Ingo Molnar
2007-08-05 10:29                                 ` Jakob Oestergaard
2007-08-05 12:46                                 ` Alan Cox
2007-08-05 12:58                                   ` Ingo Molnar
2007-08-05 13:29                                     ` Willy Tarreau
2007-08-06  6:57                                       ` Ingo Molnar
2007-08-06 13:12                                         ` Willy Tarreau
2007-08-05 14:46                               ` Theodore Tso
2007-08-05 17:55                                 ` Ingo Molnar
2007-08-05 17:59                                   ` Jeff Garzik
2007-08-05 18:09                                     ` Ingo Molnar
2007-08-05 18:08                                 ` Arjan van de Ven
2007-08-07 21:20                             ` Bill Davidsen
2007-08-05  7:18                           ` Ingo Molnar
2007-08-07 18:55                         ` Bill Davidsen
2007-08-07 19:35                           ` Alan Cox
2007-08-08 17:44                             ` Bill Davidsen
2007-08-04 20:28                       ` Ingo Molnar
2007-08-04 20:34                         ` Arjan van de Ven
2007-08-04 21:03                         ` Ingo Molnar
2007-08-04 21:51                           ` Alan Cox
2007-08-05  7:21                             ` Ingo Molnar
2007-08-05  7:29                               ` Andrew Morton
2007-08-05  7:39                                 ` Ingo Molnar
2007-08-05  8:53                               ` Willy Tarreau
2007-08-05 14:17                                 ` Jörn Engel
2007-08-05 18:02                                   ` Arjan van de Ven
2007-08-05 18:37                                     ` Jörn Engel
2007-08-05 20:21                                       ` Jörn Engel
2007-08-05 20:33                                         ` Andrew Morton
2007-08-05 12:47                               ` Alan Cox
2007-08-05 12:56                                 ` Ingo Molnar
2007-08-05 18:44                               ` Dave Jones
2007-08-05 18:58                                 ` adi
2007-08-06  6:39                                 ` Ingo Molnar
2007-08-06 15:59                                   ` Dave Jones
2007-08-06 16:16                                     ` Ingo Molnar
2007-08-05  7:37                             ` Ingo Molnar
2007-08-05  9:04                               ` Jeff Garzik
2007-08-05 12:43                               ` Alan Cox
2007-08-05 12:54                                 ` Ingo Molnar
2007-08-05 13:37                                   ` Alan Cox
2007-08-05 18:08                                     ` Ingo Molnar
2007-08-05 19:11                                       ` Alan Cox
2007-08-08 18:22                                       ` Bill Davidsen
2007-08-08 19:39                                         ` Jeff Garzik
2007-08-08 20:31                                           ` Bill Davidsen
2007-08-08 23:18                                           ` Alan Cox
2007-08-07 19:09                             ` Bill Davidsen
2007-08-04 21:48                         ` Alan Cox
2007-08-05  7:13                           ` Ingo Molnar
2007-08-05 13:22                             ` Diego Calleja
2007-08-05 19:03                               ` david
2007-08-06  6:52                                 ` Ingo Molnar
2007-08-10  4:04                                 ` Bill Davidsen
2007-08-11  5:19                                   ` Valdis.Kletnieks
2007-08-06  6:58                               ` Ingo Molnar
2007-08-09  0:57                             ` Greg Trounson
2007-08-09  1:26                               ` david
2007-08-09  2:33                               ` Andi Kleen
2007-08-04 22:39                         ` Ilpo Järvinen
2007-08-05 10:20                 ` Jakob Oestergaard
2007-08-05 10:42                   ` Jeff Garzik
2007-08-05 10:58                     ` Jakob Oestergaard
2007-08-05 12:46                       ` Ingo Molnar
2007-08-05 13:46                         ` Jakob Oestergaard
2007-08-05 16:45                         ` Linus Torvalds
2007-08-05 19:09                           ` Ingo Molnar
2007-08-05 19:22                             ` [patch] implement smarter atime updates support Ingo Molnar
2007-08-05 19:28                               ` [patch] implement smarter atime updates support, v2 Ingo Molnar
2007-08-05 20:42                                 ` Theodore Tso
2007-08-06  5:36                                   ` Ingo Molnar
2007-08-05 19:53                               ` [patch] implement smarter atime updates support Arjan van de Ven
2007-08-05 20:04                                 ` Alan Cox
2007-08-05 20:22                                   ` Arjan van de Ven
2007-08-05 19:29                             ` [PATCH 00/23] per device dirty throttling -v8 Alan Cox
2007-08-05 19:32                               ` Ingo Molnar
2007-08-05 23:43                     ` David Chinner
2007-08-05  0:26             ` Andi Kleen
2007-08-05 15:00               ` Theodore Tso
2007-08-06 13:47                 ` Chris Mason
2007-08-17  0:45                 ` Dave Jones
2007-08-05 20:41               ` Christoph Hellwig
2007-08-06 10:42                 ` Andi Kleen
2007-08-16 10:18               ` Helge Hafting
2007-08-09  6:25             ` Lionel Elie Mamane
2007-08-09 15:02               ` Chuck Ebbert
2007-08-09 16:22                 ` Diego Calleja
2007-08-04 16:41           ` Andrew Morton
2007-08-04 17:26             ` Nikita Danilov
2007-08-04 19:16             ` Florian Weimer
2007-08-05  6:00               ` Andrew Morton
2007-08-05  7:57                 ` Florian Weimer
2007-08-05 20:43                   ` Christoph Hellwig
2007-08-05 22:46               ` Theodore Tso
2007-08-06  0:24               ` David Chinner
2007-08-05  0:28         ` Andi Kleen
2007-08-04 16:15       ` Linus Torvalds
2007-08-05 17:22     ` Brice Figureau
2007-08-05 22:17       ` Andi Kleen
2007-08-06  8:40         ` Brice Figureau
2007-08-14  1:44           ` Stewart Smith
2007-08-14  2:25             ` Andi Kleen
2007-08-14  7:59               ` Brice Figureau
2007-08-06 20:26 ` Miklos Szeredi
2007-08-08 12:25 ` richard kennedy
2007-08-08 13:54   ` Andi Kleen
2007-08-10  4:17     ` Bill Davidsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070805081812.GA13572@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=david@lang.hm \
    --cc=dgc@sgi.com \
    --cc=jeff@garzik.org \
    --cc=joern@logfs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=miklos@szeredi.hu \
    --cc=neilb@suse.de \
    --cc=nikita@clusterfs.com \
    --cc=richard@rsk.demon.co.uk \
    --cc=tomoki.sekiyama.qu@hitachi.com \
    --cc=torvalds@linux-foundation.org \
    --cc=trond.myklebust@fys.uio.no \
    --cc=yingchao.zhou@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).