From: Adrian Bunk <bunk@kernel.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Al Boldi <a1426z@gawab.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
David Brownell <david-b@pacbell.net>, Greg KH <greg@kroah.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/5] USB Kconfig: Select SCSI for USB Mass Storage support
Date: Sat, 5 Jan 2008 23:03:30 +0200 [thread overview]
Message-ID: <20080105210330.GC22232@does.not.exist> (raw)
In-Reply-To: <20080105113024.209485f5.randy.dunlap@oracle.com>
On Sat, Jan 05, 2008 at 11:30:24AM -0800, Randy Dunlap wrote:
> On Sat, 5 Jan 2008 18:41:39 +0300 Al Boldi wrote:
>
> >
> > Select SCSI for USB Mass Storage support.
> >
> >
> > Cc: David Brownell <david-b@pacbell.net>
> > Cc: Greg KH <greg@kroah.com>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Signed-off-by: Al Boldi <a1426z@gawab.com>
> >
> > ---
> >
> > --- 23.a/drivers/usb/storage/Kconfig
> > +++ 23.b/drivers/usb/storage/Kconfig
> > @@ -2,14 +2,10 @@
> > # USB Storage driver configuration
> > #
> >
> > -comment "NOTE: USB_STORAGE needs SCSI, and 'SCSI disk support' may"
> > - depends on USB
> > -comment "also be needed; see USB_STORAGE Help for more information"
> > - depends on USB
> > -
> > menuconfig USB_STORAGE
> > tristate "USB Mass Storage support"
> > - depends on USB && SCSI
> > + depends on USB
> > + select SCSI
>
> We try not to use 'select' on subsystems and try to limit its use
> to library-like code that is relatively small. Selecting SCSI
> breaks both of those efforts.
>...
_You_ are trying to do this.
For kconfig users, "select" is _much_ better than sending them through
different menus.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2008-01-05 21:04 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-05 15:41 [PATCH 2/5] USB Kconfig: Select SCSI for USB Mass Storage support Al Boldi
2008-01-05 18:42 ` David Brownell
2008-01-05 19:30 ` Randy Dunlap
2008-01-05 21:03 ` Adrian Bunk [this message]
2008-01-05 21:09 ` Sam Ravnborg
2008-01-05 23:22 ` Randy Dunlap
2008-01-05 23:45 ` Adrian Bunk
2008-01-06 0:35 ` Stefan Richter
2008-01-06 0:58 ` Adrian Bunk
2008-01-06 11:29 ` Stefan Richter
2008-01-06 11:59 ` Adrian Bunk
2008-01-06 12:32 ` Stefan Richter
2008-01-06 12:58 ` Adrian Bunk
2008-01-06 13:23 ` Stefan Richter
2008-01-06 12:18 ` Stefan Richter
2008-01-06 12:37 ` Adrian Bunk
2008-01-06 13:13 ` Stefan Richter
2008-01-06 13:38 ` Adrian Bunk
2008-01-06 13:55 ` Sam Ravnborg
2008-01-06 13:57 ` Stefan Richter
2008-01-06 14:45 ` david
2008-01-06 13:41 ` Stefan Richter
2008-01-06 15:05 ` david
2008-01-06 14:08 ` Stefan Richter
2008-01-06 17:11 ` Alan Stern
2008-01-06 18:07 ` Stefan Richter
2008-01-06 1:01 ` Randy Dunlap
2008-01-06 11:54 ` Stefan Richter
2008-01-06 12:05 ` Adrian Bunk
2008-01-06 12:41 ` Stefan Richter
2008-01-06 5:03 ` Al Boldi
2008-01-06 14:39 ` Stefan Richter
2008-01-06 17:07 ` Al Boldi
2008-01-06 17:50 ` Stefan Richter
2008-01-06 18:01 ` Stefan Richter
2008-01-06 18:23 ` Sam Ravnborg
2008-01-05 20:40 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080105210330.GC22232@does.not.exist \
--to=bunk@kernel.org \
--cc=a1426z@gawab.com \
--cc=akpm@linux-foundation.org \
--cc=david-b@pacbell.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).