From: "Bruno Prémont" <bonbons@linux-vserver.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: "Américo Wang" <xiyou.wangcong@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6.33-rc5 regression] NULL pointer dereference in vlan_skb_recv - probably introduced by commit 9793241fe92f7d9303fb221e43fc598eb065f267
Date: Sun, 24 Jan 2010 20:18:08 +0100 [thread overview]
Message-ID: <20100124201808.2bbbf0b0@neptune.home> (raw)
In-Reply-To: <4B5C74BF.5060604@gmail.com>
Yep, works fine and RX stats look right as well.
So
Reported-By: Bruno Prémont <bonbons@linux-vserver.org>
Tested-By: Bruno Prémont <bonbons@linux-vserver.org>
Thanks,
Bruno
On Sun, 24 January 2010 Eric Dumazet <eric.dumazet@gmail.com> wrote:
> Ok, I believe I found the problem :)
>
> Please try following patch, if it works I'll submit with appropriate
> Changelog and signatures
>
> Thanks
>
>
> diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c
> index b788978..c1b92ca 100644
> --- a/net/8021q/vlan_dev.c
> +++ b/net/8021q/vlan_dev.c
> @@ -163,7 +163,7 @@ int vlan_skb_recv(struct sk_buff *skb, struct net_device *dev,
> goto err_unlock;
> }
>
> - rx_stats = per_cpu_ptr(vlan_dev_info(dev)->vlan_rx_stats,
> + rx_stats = per_cpu_ptr(vlan_dev_info(skb->dev)->vlan_rx_stats,
> smp_processor_id());
> rx_stats->rx_packets++;
> rx_stats->rx_bytes += skb->len;
next prev parent reply other threads:[~2010-01-24 19:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-23 15:56 [2.6.33-rc5 regression] NULL pointer dereference in vlan_skb_recv - probably introduced by commit 9793241fe92f7d9303fb221e43fc598eb065f267 Bruno Prémont
2010-01-23 21:31 ` Bruno Prémont
2010-01-24 13:42 ` Eric Dumazet
2010-01-24 15:02 ` Bruno Prémont
2010-01-24 15:25 ` Bruno Prémont
2010-01-24 16:25 ` Américo Wang
2010-01-24 16:27 ` Eric Dumazet
2010-01-24 16:26 ` Eric Dumazet
2010-01-24 19:18 ` Bruno Prémont [this message]
2010-01-24 19:43 ` [PATCH] vlan: fix vlan_skb_recv() Eric Dumazet
2010-01-25 3:52 ` David Miller
2010-01-24 7:12 ` [2.6.33-rc5 regression] NULL pointer dereference in vlan_skb_recv - probably introduced by commit 9793241fe92f7d9303fb221e43fc598eb065f267 Américo Wang
2010-01-24 7:17 ` Alexey Dobriyan
2010-01-24 7:30 ` Américo Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100124201808.2bbbf0b0@neptune.home \
--to=bonbons@linux-vserver.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).