From: Arnd Bergmann <arnd@arndb.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: David Miller <davem@davemloft.net>,
linuxppc-dev@lists.ozlabs.org, torvalds@linux-foundation.org,
paulus@au.ibm.com, linux-kernel@vger.kernel.org,
sparclinux@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: 64-bit ppc rwsem
Date: Tue, 24 Aug 2010 14:06:38 +0200 [thread overview]
Message-ID: <201008241406.38539.arnd@arndb.de> (raw)
In-Reply-To: <1282613477.22370.485.camel@pasglop>
On Tuesday 24 August 2010, Benjamin Herrenschmidt wrote:
> On Mon, 2010-08-23 at 15:18 -0700, David Miller wrote:
> > > I've seen drivers in the past do trylocks at interrupt time ... tho
> > I
> > > agree it sucks.
> >
> > Recently there was a thread where this was declared absolutely
> > illegal.
> >
> > Maybe it was allowed, or sort-of worked before, and that's why it's
> > accounted for with IRQ disables in some implementations. I don't
> > know.
>
> Ok, I'm happy to say it's a big no-no then.
>
> Arnd, do you want to take over the moving to asm-generic and take care
> of the spinlock case as well ? I can send Linus the first patch that
> changes powerpc to use atomic_long now along with a few other things I
> have pending, then you can pickup from there. Or do you want me to
> continue pushing my patch as-is and we can look at cleaning up the
> spinlock case separately ?
I'm currently doing too many things at once, please push in your existing
patch for now, we can continue from there.
For the asm-generic patch:
Acked-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2010-08-24 12:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 1:03 [GIT] Sparc David Miller
2010-08-18 1:31 ` Linus Torvalds
2010-08-18 1:59 ` Linus Torvalds
2010-08-18 2:14 ` David Miller
2010-08-18 4:38 ` 64-bit ppc rwsem (was: Re: [GIT] Sparc) Benjamin Herrenschmidt
2010-08-18 5:03 ` Benjamin Herrenschmidt
2010-08-18 5:28 ` 64-bit ppc rwsem David Miller
2010-08-18 5:39 ` Sam Ravnborg
2010-08-18 5:48 ` David Miller
2010-08-19 5:23 ` Benjamin Herrenschmidt
2010-08-19 5:29 ` David Miller
2010-08-19 10:24 ` Benjamin Herrenschmidt
2010-08-20 5:14 ` [PATCH 1/2] powerpc: Make rwsem use "long" type Benjamin Herrenschmidt
2010-08-24 1:37 ` Timur Tabi
2010-08-20 5:14 ` [PATCH 2/2] rwsem: Move powerpc atomic-long based implementation to asm-generic Benjamin Herrenschmidt
2010-08-20 6:43 ` Sam Ravnborg
2010-08-24 1:32 ` Benjamin Herrenschmidt
2010-08-23 4:39 ` David Miller
2010-08-23 13:44 ` 64-bit ppc rwsem Arnd Bergmann
2010-08-23 22:01 ` Benjamin Herrenschmidt
2010-08-23 22:18 ` David Miller
2010-08-24 1:31 ` Benjamin Herrenschmidt
2010-08-24 12:06 ` Arnd Bergmann [this message]
2010-08-18 2:12 ` [GIT] Sparc David Miller
2010-08-18 2:50 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008241406.38539.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@au.ibm.com \
--cc=sparclinux@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).