linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Joe Perches <joe@perches.com>
Cc: Jiri Kosina <trivial@kernel.org>,
	Ian Lartey <ian@opensource.wolfsonmicro.com>,
	Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
	Liam Girdwood <lrg@slimlogic.co.uk>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 44/44] sound/soc/codecs: Remove unnecessary semicolons
Date: Tue, 16 Nov 2010 10:49:22 +0000	[thread overview]
Message-ID: <20101116104921.GL12986@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1289850773.16461.166.camel@Joe-Laptop>

On Mon, Nov 15, 2010 at 11:52:53AM -0800, Joe Perches wrote:
> On Mon, 2010-11-15 at 19:34 +0000, Mark Brown wrote:

> > It appears your scripts are already hooked into get_maintainers.pl which
> > would seem the obvious place to do this?  Sadly I don't do perl, though
> > it looks like you're doing pretty much all the work on that anyway.

> Sadly, no it's not the right place.

To query MAINTAINERS?  I'd assume that's where you'd want to put that
stuff?

> There could be a modification to $1 (path)
> or some such.
> 
> Maybe a script like
> ./scripts/convert_commit_subject_to_subsystem_maintainer_taste
> or something.

> Care to write one in sh/bash/perl/python/c/ocaml/c#?

Like I say I'd expect this to be a get_maintainers based lookup to dump
some data out?

> As far as I know, the only subsystem pedants^H^H^H^H^Hople
> that care much about the commit subject style are
> arch/x86 and sound.

If you look at the kernel you'll see quite a few subsystems which have
some sort of standard practice which they do try to enforce, you
shouldn't take silence as people being happy here - it's taken me some
considerable time to get round to mentioning this, for example, and I
might not have bothered if the patch had applied first time around.
Like working against -next it's one of these things that would make your
patches easier to deal with.

> I can understand the desire of these subsystem maintainers
> to have a consistent style.  I think though that requiring
> a subject header style without providing more than a
> general guideline is a but much.

The general guideline I tend to go with is that if what you're doing
looks odd for the code you're submitting against for some reason you're
doing something wrong unless you understand why you're doing something
different and there's a good reason.

> I'd use any other automated tool you want to provide.

Like I say, I'd expect the lookup from the database to be handled by
get_maintainers.pl.  Having a separate database would seem odd.

  reply	other threads:[~2010-11-16 10:49 UTC|newest]

Thread overview: 100+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-15  3:04 [PATCH 00/44] remove unnecessary semicolons Joe Perches
2010-11-15  3:04 ` [PATCH 01/44] arch/arm: Remove " Joe Perches
2010-11-15  3:04 ` [PATCH 02/44] arch/microblaze: " Joe Perches
2010-11-15  6:37   ` Michal Simek
2010-11-15  3:04 ` [PATCH 03/44] arch/um: " Joe Perches
2010-11-15  3:04 ` [PATCH 04/44] drivers/cpufreq: " Joe Perches
2010-11-15  3:04 ` [PATCH 05/44] drivers/gpio: " Joe Perches
2010-11-15  3:04 ` [PATCH 06/44] drivers/i2c: " Joe Perches
2010-11-15  3:04 ` [PATCH 07/44] drivers/isdn: " Joe Perches
2010-11-15 19:08   ` David Miller
2010-11-15  3:04 ` [PATCH 08/44] drivers/leds: " Joe Perches
2010-11-15  3:04 ` [PATCH 09/44] drivers/media/video: " Joe Perches
2010-11-15  3:04 ` [PATCH 10/44] drivers/misc: " Joe Perches
2010-11-15  3:04 ` [PATCH 11/44] drivers/mmc: " Joe Perches
2010-12-05  3:32   ` Chris Ball
2010-11-15  3:04 ` [PATCH 12/44] drivers/net/bnx2x: " Joe Perches
2010-11-15 19:08   ` David Miller
2010-11-15  3:04 ` [PATCH 13/44] drivers/net/e1000e: " Joe Perches
2010-11-15 19:08   ` David Miller
2010-11-15  3:04 ` [PATCH 14/44] drivers/net/ixgbe: " Joe Perches
2010-11-15 16:24   ` Rose, Gregory V
2010-11-15 19:08   ` David Miller
2010-11-15  3:04 ` [PATCH 15/44] drivers/net/vxge: " Joe Perches
2010-11-15 19:07   ` David Miller
2010-11-15  3:04 ` [PATCH 16/44] drivers/net/wireless/ath: " Joe Perches
2010-11-15  3:04 ` [PATCH 17/44] drivers/net/wireless/iwlwifi: " Joe Perches
2010-11-15  3:04 ` [PATCH 18/44] drivers/net/cnic.c: " Joe Perches
2010-11-15 19:08   ` David Miller
2010-11-15  3:04 ` [PATCH 19/44] drivers/platform/x86: " Joe Perches
2010-11-24 16:52   ` Matthew Garrett
2010-11-15  3:04 ` [PATCH 20/44] drivers/power: " Joe Perches
2010-11-15  3:04 ` [PATCH 21/44] drivers/s390/net: " Joe Perches
2010-11-15 19:08   ` David Miller
2010-11-15  3:04 ` [PATCH 22/44] drivers/scsi/be2iscsi: " Joe Perches
2010-11-15  3:04 ` [PATCH 23/44] drivers/scsi/bfa: " Joe Perches
2010-11-15  3:04 ` [PATCH 24/44] drivers/scsi/lpfc: " Joe Perches
2010-11-15  3:04 ` [PATCH 25/44] drivers/scsi/pm8001: " Joe Perches
2010-11-15  3:27   ` Jack Wang
2010-11-15  3:04 ` [PATCH 26/44] drivers/scsi/qla2xxx: " Joe Perches
2010-11-15  3:04 ` [PATCH 27/44] drivers/serial: " Joe Perches
2010-11-15  3:04 ` [PATCH 28/44] drivers/spi: " Joe Perches
2010-11-15  3:57   ` Grant Likely
2010-11-15  3:04 ` [PATCH 29/44] drivers/staging: " Joe Perches
2010-11-15  3:04 ` [PATCH 30/44] drivers/usb/gadget: " Joe Perches
2010-11-15  3:04 ` [PATCH 31/44] drivers/xen: " Joe Perches
2010-11-15  3:04 ` [PATCH 32/44] fs/9p: " Joe Perches
2010-11-15  3:04 ` [PATCH 33/44] fs/ceph: " Joe Perches
2010-11-15  3:04 ` [PATCH 34/44] fs/logfs: " Joe Perches
2010-11-15  3:04 ` [PATCH 35/44] fs/nfs: " Joe Perches
2010-11-15  3:04 ` [PATCH 36/44] fs/ocfs2: " Joe Perches
2010-11-17  0:10   ` Joel Becker
2010-11-15  3:04 ` [PATCH 37/44] fs/ubifs: " Joe Perches
2010-11-19 13:21   ` Artem Bityutskiy
2010-11-15  3:04 ` [PATCH 38/44] include/linux/if_macvlan.h: " Joe Perches
2010-11-15 19:07   ` David Miller
2010-11-15  3:04 ` [PATCH 39/44] include/net/caif/cfctrl.h: " Joe Perches
2010-11-15  7:12   ` Sjur BRENDELAND
2010-11-15 19:07   ` David Miller
2010-11-15  3:04 ` [PATCH 40/44] mm/hugetlb.c: " Joe Perches
2010-11-15  9:52   ` Mel Gorman
2010-11-15  3:05 ` [PATCH 41/44] net/ipv6/mcast.c: " Joe Perches
2010-11-15 19:07   ` David Miller
2010-11-15  3:05 ` [PATCH 42/44] net/sunrpc/addr.c: " Joe Perches
2010-11-15  3:05 ` [PATCH 43/44] sound/core/pcm_lib.c: " Joe Perches
2010-11-22  6:44   ` Takashi Iwai
2010-11-15  3:05 ` [PATCH 44/44] sound/soc/codecs: " Joe Perches
2010-11-15 11:09   ` Liam Girdwood
2010-11-15 13:49   ` Mark Brown
2010-11-15 17:09     ` Joe Perches
2010-11-15 17:30       ` Mark Brown
2010-11-15 17:34         ` Joe Perches
2010-11-15 18:27           ` Mark Brown
2010-11-15 18:30             ` Joe Perches
2010-11-15 19:07               ` Mark Brown
2010-11-15 19:14                 ` Joe Perches
2010-11-15 19:34                   ` Mark Brown
2010-11-15 19:52                     ` Joe Perches
2010-11-16 10:49                       ` Mark Brown [this message]
2010-11-16 14:51                         ` rfc: rewrite commit subject line for subsystem maintainer preference tool Joe Perches
2010-11-16 15:04                           ` Mark Brown
2010-11-16 17:37                           ` Florian Mickler
2010-11-16 18:12                             ` Mark Brown
2010-11-16 19:35                               ` Florian Mickler
2010-11-16 19:55                                 ` Mark Brown
2010-11-16 20:21                                   ` Randy Dunlap
2010-11-16 20:42                                     ` Joe Perches
2010-11-16 20:46                                       ` Randy Dunlap
2010-11-16 23:22                                         ` Mark Brown
2010-11-16 23:28                                           ` Randy Dunlap
2010-11-16 23:50                                             ` Mark Brown
2010-11-16 23:57                                             ` Joe Perches
2010-11-17  0:55                                               ` Randy Dunlap
2010-11-16 23:57                                           ` Joe Perches
2010-11-16 23:01                                     ` Mark Brown
2010-11-17  0:44                                       ` Stefan Richter
2010-11-17  0:53                                         ` Jiri Kosina
2010-11-17 17:07                                           ` Mark Brown
2010-11-17 21:07                                             ` Stefan Richter
2010-11-17 23:49                                               ` Joe Perches
2010-11-17 19:32           ` [PATCH 44/44] sound/soc/codecs: Remove unnecessary semicolons Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101116104921.GL12986@rakim.wolfsonmicro.main \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=dp@opensource.wolfsonmicro.com \
    --cc=ian@opensource.wolfsonmicro.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@slimlogic.co.uk \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.de \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).