From: Shawn Guo <shawn.guo@freescale.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Shawn Guo <shawn.guo@linaro.org>, <linaro-dev@lists.linaro.org>,
<sameo@linux.intel.com>, <patches@linaro.org>,
<devicetree-discuss@lists.ozlabs.org>,
<linux-mmc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/5] make sdhci device drivers self registered
Date: Mon, 21 Mar 2011 20:52:34 +0800 [thread overview]
Message-ID: <20110321125233.GA28098@S2100-06.ap.freescale.net> (raw)
In-Reply-To: <201103211339.45305.arnd@arndb.de>
On Mon, Mar 21, 2011 at 01:39:45PM +0100, Arnd Bergmann wrote:
[...]
>
> Hi Shawn,
>
Hi Arnd,
> The changes you make look very nice, great work there!
>
> I think the split of the series into five patches is not ideal
> because you have more interdependencies than necessary, and it's
> not clear that the series can be safely bisected, especially
> with the way you do all the Kconfig/Makefile updates at the
> end.
>
> A nicer way to partition the series would be
>
> 1. Add sdhci_pltfm_init helper
> 2-5. Convert each of the users, including the respective
> Kconfig/Makefile changes
> 6. remove obsolete code from sdhci-pltfm.c
>
> As I said, that's just a detail and the end result is the same.
> If you don't get any other feedback and Chris is happy with the
> changes, I wouldn't expect you to reshuffle all the patches just
> for this.
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
>
Actually, I knew there should be better partition of the patch set,
and it just did not come into my mind :) You suggestion does look
better. I would take it in the next spin.
Thanks for the suggestion.
--
Regards,
Shawn
next prev parent reply other threads:[~2011-03-21 12:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-21 8:06 [PATCH 0/5] make sdhci device drivers self registered Shawn Guo
2011-03-21 8:06 ` [PATCH 1/5] mmc: sdhci: make sdhci-esdhc-imx driver " Shawn Guo
2011-03-24 4:28 ` Grant Likely
2011-03-25 9:36 ` Shawn Guo
2011-03-21 8:07 ` [PATCH 2/5] mmc: sdhci: make sdhci-cns3xxx " Shawn Guo
2011-03-21 8:07 ` [PATCH 3/5] mmc: sdhci: make sdhci-dove " Shawn Guo
2011-03-21 8:07 ` [PATCH 4/5] mmc: sdhci: make sdhci-tegra " Shawn Guo
2011-03-21 8:07 ` [PATCH 5/5] mmc: sdhci: update Makefile/Kconfig for sdhci_pltfm change Shawn Guo
2011-03-21 12:39 ` [PATCH 0/5] make sdhci device drivers self registered Arnd Bergmann
2011-03-21 12:52 ` Shawn Guo [this message]
2011-03-21 12:54 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110321125233.GA28098@S2100-06.ap.freescale.net \
--to=shawn.guo@freescale.com \
--cc=arnd@arndb.de \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=sameo@linux.intel.com \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).