From: Jason Baron <jbaron@redhat.com>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Bart Van Assche <bvanassche@acm.org>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
greg@kroah.com
Subject: Re: linux-next: Tree for Aug 24 (dynamic_debug)
Date: Wed, 24 Aug 2011 15:32:45 -0400 [thread overview]
Message-ID: <20110824193244.GA2540@redhat.com> (raw)
In-Reply-To: <20110824102551.8fc076b5.rdunlap@xenotime.net>
On Wed, Aug 24, 2011 at 10:25:51AM -0700, Randy Dunlap wrote:
> On Wed, 24 Aug 2011 16:04:04 +1000 Stephen Rothwell wrote:
>
> > Hi all,
>
> When CONFIG_NET is not enabled (I see this on i386 builds):
>
> lib/built-in.o: In function `__dynamic_netdev_dbg':
> (.text+0x9fda): undefined reference to `__netdev_printk'
>
> ---
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code ***
Ok, we probably want something, like below, although something keeps
selecting CONFIG_NET, when I try to unset it, in my .config...so not yet
tested, but should work.
Thanks,
-Jason
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index ee3b9ba..e4760de 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -504,6 +504,8 @@ int __dynamic_dev_dbg(struct _ddebug *descriptor,
}
EXPORT_SYMBOL(__dynamic_dev_dbg);
+#ifdef CONFIG_NET
+
int __dynamic_netdev_dbg(struct _ddebug *descriptor,
const struct net_device *dev, const char *fmt, ...)
{
@@ -528,6 +530,8 @@ int __dynamic_netdev_dbg(struct _ddebug *descriptor,
}
EXPORT_SYMBOL(__dynamic_netdev_dbg);
+#endif
+
static __initdata char ddebug_setup_string[1024];
static __init int ddebug_setup_query(char *str)
{
next prev parent reply other threads:[~2011-08-24 19:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 6:04 linux-next: Tree for Aug 24 Stephen Rothwell
2011-08-24 17:25 ` linux-next: Tree for Aug 24 (dynamic_debug) Randy Dunlap
2011-08-24 19:32 ` Jason Baron [this message]
2011-08-24 19:42 ` Randy Dunlap
2011-08-24 21:09 ` Greg KH
2011-09-26 23:17 ` David Brown
2011-09-27 13:27 ` Jason Baron
2011-08-25 1:38 ` linux-next: Tree for Aug 24 Arnaud Lacombe
2011-08-25 4:30 ` Arnaud Lacombe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110824193244.GA2540@redhat.com \
--to=jbaron@redhat.com \
--cc=bvanassche@acm.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).