From: Oleg Nesterov <oleg@redhat.com>
To: Mandeep Singh Baines <msb@chromium.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Li Zefan <lizf@cn.fujitsu.com>, Tejun Heo <tj@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Containers <containers@lists.linux-foundation.org>,
Cgroups <cgroups@vger.kernel.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Paul Menage <paul@paulmenage.org>,
Andrew Morton <akpm@linux-foundation.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: Re: Q: cgroup: Questions about possible issues in cgroup locking
Date: Fri, 13 Jan 2012 16:20:10 +0100 [thread overview]
Message-ID: <20120113152010.GA19215@redhat.com> (raw)
In-Reply-To: <20120112175725.GD9511@google.com>
On 01/12, Mandeep Singh Baines wrote:
>
> Oleg Nesterov (oleg@redhat.com) wrote:
> >
> > Still can't understand... Lets look at this trivial example again.
> >
> > We start from the main thread M, it is ->group_leader. There is
> > another thread T in this thread group. We are doing
> >
> > OLD = M;
> >
> > t = M;
> > do {
> > do_smth(t);
> > }
> > while (t->group_leader == OLD && ((t = next_thread(t)) != M);
> >
> > The first iteration does do_smth(M).
> >
> > T calls de_thread() and, in particular, it does M->group_leader = T
> > (see "leader->group_leader = tsk" in de_thread).
> >
> > after that t->group_leader == OLD fails. t == M, its group_leader == T.
> > do_smth(T) won't be called.
> >
> > No?
> >
>
> I think we can handle this by removing the assignment. So in de_thread():
>
> - leader->group_leader = tsk;
Ah, so that was you plan. I was confused by the 3rd argument, why
it is needed?
Yes, I thought about this too. Suppose we remove this assignment,
then we can simply do
#define while_each_thread(g, t) \
while (t->group_leader == g->group_leader && (t = next_thread(t)) != g)
with the same effect. (to remind, currently I ignore the barriers/etc).
But this can _only_ help if we start at the group leader!
May be we should enforce this rule (for the lockless case), I dunno...
In that case I'd prefer to add the new while_each_thread_rcu() helper.
But! in this case we do not need to change de_thread(), we can simply do
#define while_each_thread_rcu(t) \
while (({ t = next_thread(t); !thread_group_leader(t); }))
The definition above was one of the possibilities I considered, but
I wasn't able to convince myself this is the best option.
See? Or do you think I missed something?
Just in case... note that while_each_thread_rcu() doesn't use 'g'
at all. May be it makes sense to keep the old "t != g &&", but this
is minor.
Oleg.
next prev parent reply other threads:[~2012-01-13 15:59 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-21 3:43 Q: cgroup: Questions about possible issues in cgroup locking Frederic Weisbecker
2011-12-21 13:08 ` Oleg Nesterov
2011-12-21 17:56 ` Frederic Weisbecker
2011-12-21 19:01 ` Mandeep Singh Baines
2011-12-21 19:08 ` Frederic Weisbecker
2011-12-21 19:24 ` Mandeep Singh Baines
2011-12-21 20:04 ` Frederic Weisbecker
2011-12-22 15:30 ` Oleg Nesterov
2012-01-04 19:36 ` Mandeep Singh Baines
2012-01-06 15:23 ` Oleg Nesterov
2012-01-06 18:25 ` Mandeep Singh Baines
2012-01-11 16:07 ` Oleg Nesterov
2012-01-12 0:31 ` Mandeep Singh Baines
2012-01-12 17:07 ` Oleg Nesterov
2012-01-12 17:57 ` Mandeep Singh Baines
2012-01-13 15:20 ` Oleg Nesterov [this message]
2012-01-13 18:27 ` Mandeep Singh Baines
2012-01-14 17:36 ` Oleg Nesterov
2012-01-18 23:17 ` Mandeep Singh Baines
2012-01-19 15:45 ` Oleg Nesterov
2012-01-19 18:18 ` Mandeep Singh Baines
2012-01-20 15:06 ` Oleg Nesterov
2012-03-20 19:34 ` Oleg Nesterov
2012-03-21 18:59 ` Mandeep Singh Baines
2012-03-23 17:51 ` Oleg Nesterov
2011-12-21 17:59 ` Frederic Weisbecker
2011-12-21 18:11 ` Oleg Nesterov
2011-12-21 18:23 ` Frederic Weisbecker
2012-02-01 16:28 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120113152010.GA19215@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=containers@lists.linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=msb@chromium.org \
--cc=paul@paulmenage.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).