From: Andrew Morton <akpm@linux-foundation.org>
To: Dan Magenheimer <dan.magenheimer@oracle.com>
Cc: Dave Hansen <dave@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Konrad Wilk <konrad.wilk@oracle.com>,
Seth Jennings <sjenning@linux.vnet.ibm.com>,
Nitin Gupta <ngupta@vflare.org>,
Nebojsa Trpkovic <trx.lists@gmail.com>,
minchan@kernel.org,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
riel@redhat.com, Chris Mason <chris.mason@oracle.com>
Subject: Re: [PATCH] mm: implement WasActive page flag (for improving cleancache)
Date: Thu, 26 Jan 2012 16:31:50 -0800 [thread overview]
Message-ID: <20120126163150.31a8688f.akpm@linux-foundation.org> (raw)
In-Reply-To: <9fcd06f5-360e-4542-9fbb-f8c7efb28cb6@default>
On Thu, 26 Jan 2012 13:28:02 -0800 (PST)
Dan Magenheimer <dan.magenheimer@oracle.com> wrote:
> > I do think it also needs to get cleared on the way in to the page
> > allocator. Otherwise:
> >
> > PageSetWasActive(page);
> > free_page(page);
> > ...
> > another_user_page = get_free_page()
> > // now cleancache sees the active bit for the prev user
> >
> > Or am I missing somewhere it gets cleared non-explicitly somewhere?
>
> True, it is not getting cleared and it should be, good catch!
It should be added to PAGE_FLAGS_CHECK_AT_FREE.
> I'll find the place to add the call to ClearPageWasActive() for v2.
AFAICT this patch consumes our second-last page flag, or close to it.
We'll all be breaking out in hysterics when the final one is gone.
This does appear to be a make or break thing for cleancache - if we
can't fix https://lkml.org/lkml/2012/1/22/61 then cleancache is pretty
much a dead duck. But I'm going to ask for great effort to avoid
consuming another page flag. Either fix cleancache via other means or,
much less desirably, find an existing page flag and overload it.
And I'm afraid that neither I nor other MM developers are likely to
help you with "fix cleancache via other means" because we weren't
provided with any description of what the problem is within cleancache,
nor how it will be fixed. All we are given is the assertion "cleancache
needs this".
next prev parent reply other threads:[~2012-01-27 0:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-25 21:58 [PATCH] mm: implement WasActive page flag (for improving cleancache) Dan Magenheimer
2012-01-26 17:28 ` Dave Hansen
2012-01-26 21:28 ` Dan Magenheimer
2012-01-27 0:31 ` Andrew Morton [this message]
2012-01-27 0:56 ` Dan Magenheimer
2012-01-27 1:15 ` Andrew Morton
2012-01-27 2:43 ` Dan Magenheimer
2012-01-27 3:33 ` Rik van Riel
2012-01-27 5:15 ` Dan Magenheimer
2012-01-30 8:57 ` KAMEZAWA Hiroyuki
2012-01-30 22:03 ` Dan Magenheimer
2012-01-27 13:43 ` James Bottomley
2012-01-27 17:32 ` Dan Magenheimer
2012-01-27 17:54 ` James Bottomley
2012-01-27 18:46 ` Dan Magenheimer
2012-01-27 21:49 ` James Bottomley
2012-01-29 0:50 ` Rik van Riel
2012-01-29 22:25 ` James Bottomley
2012-01-27 3:28 ` Rik van Riel
2012-01-27 5:11 ` Dan Magenheimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120126163150.31a8688f.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=chris.mason@oracle.com \
--cc=dan.magenheimer@oracle.com \
--cc=dave@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=riel@redhat.com \
--cc=sjenning@linux.vnet.ibm.com \
--cc=trx.lists@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).