From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Liam Girdwood <lrg@ti.com>, Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH 3/3] ASoC: codecs: add driver for max9768 amplifier
Date: Fri, 27 Jan 2012 16:25:01 +0000 [thread overview]
Message-ID: <20120127162501.GA18572@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1327677023-29310-3-git-send-email-w.sang@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1505 bytes --]
On Fri, Jan 27, 2012 at 04:10:23PM +0100, Wolfram Sang wrote:
> Mark: Still no DAPM support. We don't have PM on this board, and since I
> couldn't easily figure what is expected from me here, I'd like to leave this
> for people who have real interest in that.
I don't understand what was unclear here...
You should at least use set_bias_level() to manage the shutdown GPIO I
guess.
> +static const struct snd_kcontrol_new max9768_volume[] = {
> + SOC_SINGLE_TLV("Playback Volume", MAX9768_VOL, 0, 63, 0, volume_tlv),
> +};
> +static const struct snd_kcontrol_new max9768_mute[] = {
> + SOC_SINGLE_BOOL_EXT("Mute Switch", 0, max9768_get_gpio, max9768_set_gpio),
> +};
Should be "Playback Switch" to match the volume control - that way
userspace can present a single control to applications.
> +static bool max9768_always_false(struct device *dev, unsigned int reg)
> +{
> + return false;
> +}
This should be the default in regmap for formats that use format_write
(and hence can't read back), please fix in regmap rather than add this.
> + if (pdata) {
> + /* Mute on powerup to avoid clicks */
> + err = gpio_request_one(pdata->mute_gpio, GPIOF_INIT_HIGH, "MAX9768 Mute");
This need to avoid clicks is the reason I was asking for the DAPM stuff.
> + /* Activate chip by releasing shutdown, enables I2C */
> + err = gpio_request_one(pdata->shdn_gpio, GPIOF_INIT_HIGH, "MAX9768 Shutdown");
> + max9768->shdn_gpio = err ?: pdata->shdn_gpio;
Eeew.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-01-27 16:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-27 15:10 [PATCH 1/3] regmap: Properly round reg_bytes and val_bytes Wolfram Sang
2012-01-27 15:10 ` [PATCH 2/3] regmap: Add support for 2/6 register formating Wolfram Sang
2012-01-27 16:28 ` Mark Brown
2012-01-27 15:10 ` [PATCH 3/3] ASoC: codecs: add driver for max9768 amplifier Wolfram Sang
2012-01-27 16:25 ` Mark Brown [this message]
2012-01-30 21:54 ` [alsa-devel] " Mark Brown
2012-01-27 16:28 ` [PATCH 1/3] regmap: Properly round reg_bytes and val_bytes Mark Brown
2012-01-28 1:14 ` Wolfram Sang
2012-01-30 13:21 ` Mark Brown
2012-01-30 13:35 ` Wolfram Sang
2012-01-30 13:45 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120127162501.GA18572@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).