linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Richard Weinberger <richard@nod.at>
Cc: user-mode-linux-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] um: Use generic io.h
Date: Mon, 30 Jan 2012 19:25:52 +0000	[thread overview]
Message-ID: <20120130192552.GL23916@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20120130182333.GK23916@ZenIV.linux.org.uk>

On Mon, Jan 30, 2012 at 06:23:33PM +0000, Al Viro wrote:
> On Wed, Jan 25, 2012 at 06:23:53PM +0100, Richard Weinberger wrote:
> > There is no need to implement our own basic io functions.
> > All we need exists already in asm-generic/io.h
> 
> Then just do
> 
> git rm arch/um/include/asm/io.h
> echo 'generic-y += io.h' >>arch/um/include/asm/Kbuild
> git add arch/um/include/asm/Kbuild
> 
> and be done with that.  We are already using generic-y for a bunch of
> headers there...

While we are at it, param.h and pci.h appear to be candidates for the
same treatment, along with delay.h and auxvec.h.  mutex.h as well...
BTW, we probably can kill arch/um/include/asm/asm-offsets.h - everything
in there is using generated/asm-offsets.h directly.

FWIW, I'd probably kill current.h as well - replace get_current() in
arch/um/kernel/process.c with get_current_pid() (i.e. task_pid_nr(current)),
kill HOST_TASK_PID and switch arch/x86/um/bugs_32.c to use of get_current_pid()
and we can switch to asm-generic/current.h just fine.

  parent reply	other threads:[~2012-01-30 19:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-25 17:23 [PATCH 1/2] um: Use generic io.h Richard Weinberger
2012-01-25 17:23 ` [PATCH 2/2] um: Serve io_remap_pfn_range() Richard Weinberger
2012-01-30 18:23 ` [PATCH 1/2] um: Use generic io.h Al Viro
2012-01-30 19:10   ` Richard Weinberger
2012-01-30 19:25   ` Al Viro [this message]
2012-01-30 19:32     ` Al Viro
2012-01-30 19:57       ` Richard Weinberger
2012-02-03 23:17     ` [PATCH] um: Cleanup headers files Richard Weinberger
2012-02-04  0:14       ` Al Viro
2012-02-04  0:26         ` Richard Weinberger
2012-02-04  0:44         ` Richard Weinberger
2012-02-12 20:27           ` Al Viro
2012-02-12 21:01             ` Richard Weinberger
2012-02-12 21:20               ` Al Viro
2012-02-12 21:26                 ` Richard Weinberger
2012-02-12 21:28                   ` Al Viro
2012-02-04 14:05         ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120130192552.GL23916@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=richard@nod.at \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).