On Mon, Jan 30, 2012 at 11:25:34AM -0600, Ramirez Luna, Omar wrote: > > +                       pr_info("%s:%d handle(s) still opened\n", __func__, > > +                               atomic_read(&bridge_cref)); > > I remember the rule was to break lines as far to the right as > possible, no? Chapter 2 CodingStyle, same for the other similar > changes. > It doesn't mean you have to right justify things, it just means indented. The original code is fine here and the new code is fine here. It's up to whoever writes the code to decide. regards, dan carpenter